Commit Graph

90 Commits

Author SHA1 Message Date
Chomp 74a5310de0 Added nullguards surrounding laser and nvg checks 2025-05-28 11:44:14 +01:00
qe201020335 d3a819b00f Optimize chatbot with dictionary 2025-05-26 01:07:38 -04:00
hulkhan22 aef3a4202f Fix presentation of messages with items (rewards & insurance returns) (#265) 2025-05-21 22:29:34 +01:00
Chomp d88db583c1 Moved ItemSize into modules section, changed to record
Updated `GetItemSize` to accept `ICollection` instead of list
2025-05-21 11:34:02 +01:00
Chomp 8b3a5bbb90 Converted method comments to c# style
Made some protected properties readonly / static
2025-05-21 11:14:49 +01:00
Chomp 77547114de Converted comments to c# style inside AssortHelper
Improved readability of `RemoveItemFromAssort`
2025-05-21 10:57:54 +01:00
Chomp c9e28e05bb Moved in-game reward check even further up chain into ApplyQuestReward()
Replaced magic strings with string consts inside `IngameTraders` collection

Various comment improvements
2025-05-21 10:42:13 +01:00
Chomp e41002dc01 improved readability of GetQuestFromDb()
Added nullguards
Flagged return as nullable
2025-05-21 10:41:24 +01:00
Chomp da9920af49 Fixed typo 2025-05-21 10:38:37 +01:00
Chomp e41d4a10bf Added nullguards inside ApplyMoneyBoost()
Renamed variables to improve clarity
Converted comments
2025-05-21 10:37:51 +01:00
Chris Adamson e14f216209 skip btr driver and lightkeeper quest rewards (#262)
* skip btr driver and lightkeeper quest rewards

* remove new line

* fixed circular dep

* fixes based on feedback

* more feedback fixes
2025-05-20 23:02:55 +01:00
Chomp 604137bad1 Improved various comments inside ItemHelper
Moved values out of `ArmorItemCanHoldMods` and into frozen set

Added Tpls to spelling dictionary

Changed list parameters to be `ienumerable` or `icollection` where possible

Made `ArmorItemHasRemovablePlateSlots` use class property directly

Made `ItemHasSlots` return false when checked item doesn't exist instead of throwing an unhandled exception

Folded `HasBuyRestrictions` logic into one line
2025-05-20 12:34:22 +01:00
Chomp c8ad685081 Improved HasItemWithTpl and GetItemFromPoolByTpl 2025-05-20 12:00:01 +01:00
Chomp a9c33e1dfc Improved IsAttachmentAttached comments 2025-05-20 10:54:32 +01:00
Chomp 7fe20a49c9 Use nameof inplace of toString for _slotsAsStrings values 2025-05-20 10:51:49 +01:00
hulkhan22 8ad9afebaa fix: Insurance removing unremovable parts - #196 (#260)
* Fix insurance removing unremovable parts

* Mini optimization
2025-05-20 10:50:27 +01:00
Chris Adamson 914d151461 fixed two bugs in commando commands (#258)
* fixed two bugs in commando commands

* added count checking in other helper

* fixes based on feedback
2025-05-18 20:35:35 +01:00
hulkhan22 21382a1e06 Fix server exception at raid end when client sends bantype data (#257) 2025-05-18 19:38:13 +01:00
hulkhan22 1eb4d55a02 feat: Make adding new traders easier (#251)
* Make adding a new trader easier

* Improvements
2025-05-11 20:12:26 +01:00
Archangel 19c8c5e401 Use SptWebSocketConnectionHandler directly 2025-05-06 14:50:22 +02:00
Alex 1499627d3c DI completely reworked to keep status of singletons on multi type components 2025-05-06 10:52:22 +01:00
Chomp ae98f57bd9 Replaced various string.toLower() == x checks with string.Equals 2025-05-05 14:03:57 +01:00
hulkhan22 23468cf0a3 fix: Bot flashlights on during daytime raid (#236)
* Fix flashlights being on during daytime raids

* Add comment for the new property
2025-05-05 09:07:26 +01:00
Chomp 96570b0eb3 Fixed GetInRaidTime ignored passed in value
Improved accuracy of time simulation
2025-05-04 16:06:39 +01:00
Chomp 81ee7181c7 Split GetInRaidTime into 2 methods 2025-05-04 15:27:55 +01:00
Chomp da05351288 formatting cleanup of GetInRaidTime 2025-05-04 14:10:13 +01:00
Chomp 4ea63711a9 Fixed IsNightTime not handling factory night/day raids 2025-05-04 14:02:09 +01:00
Chomp bd5f7df3d8 Fixed IsNightTime not returning the correct value, fixes #233 2025-05-04 13:12:57 +01:00
Chomp 31ae5feb41 Bot generation performance (#231)
* chore: Bot generation performance improvements (#227)

* Bot generation performance improvements

* Revert debug logging logic

* Get rid of Info log which is bound to be printed inevitably at each bot wave generation

* Use assault const

* Removed comments

Removed lowercase side constants
Renamed equipment role to better explain its purpose

Fixed `Blocks` property being serialised to client

Updated `_slotsWithNoCompatIssues` to use existing enum type

Reduced log line to be debug

* Fixed `GetRandomTextThatMatchesPartialKey` incorrectly checking eft locales instead of spt locales

* Updated various methods to be protected

---------

Co-authored-by: hulkhan22 <clandestine984@gmail.com>
Co-authored-by: Chomp <dev@dev.sp-tarkov.com>
2025-05-04 12:51:45 +01:00
Chris Adamson e3192a7487 fixed missing bonuses in quest rewards (#229)
* fixed missing bonuses in quest rewards

* fixes based on feedback

---------

Co-authored-by: Chomp <27521899+chompDev@users.noreply.github.com>
2025-05-03 22:26:04 +01:00
Chomp b904e18456 Improved GetContainerMap access of an array by index + some formatting issues 2025-05-03 15:44:40 +01:00
CWX 7d3833c27f Update var naming to be easier to read 2025-05-03 13:07:05 +01:00
CWX 2490747921 fix weapon size calculation 2025-05-03 13:06:06 +01:00
Chomp 344ea6de35 Moved container methods around
Added code to validate items fit into airdrop crate

Updated `CreateForcedLoot` and `CreateRandomLoot` to return items with their children

Updated `SetFoundInRaid` to not add a upd to money/currency if it doesn't already have one
2025-05-02 19:48:28 +01:00
CWX a0bc2803f6 add upd check 2025-05-02 17:13:36 +01:00
Chomp 1976218991 Updated locations where we parse a number stored as a string into a double to use CultureInfo.InvariantCulture, this resolves errors with languages that don't use commas instead of periods in numbers 2025-05-01 17:41:54 +01:00
CWX 44c5a488c8 fix checking null or empty 2025-04-30 15:33:01 +01:00
Chris Adamson 9fb8b62630 remove logs 2025-04-29 12:45:36 -05:00
Chris Adamson de38f1fe88 try just the enum 2025-04-29 10:57:12 -05:00
Chomp 760f3e3c72 Revert "fixed error where itemlocation can be either a string or int" 2025-04-29 08:47:44 +01:00
Chris Adamson 723e616e80 fixes based on feedback 2025-04-28 12:43:11 -05:00
Chris Adamson 7ed081d305 fixed error where itemlocation can be either a string or int 2025-04-28 12:07:46 -05:00
hulkhan22 ac41596aef Convert to .GetValueOrDefault() 2025-04-27 21:43:24 +02:00
hulkhan22 53d3c7fcce Convert to .GetValueOrDefault() 2025-04-27 21:41:55 +02:00
hulkhan22 36a23f0d43 Revert nullable ref 2025-04-27 20:41:04 +02:00
hulkhan22 bf12e2f400 Fix productions not advancing without generator on 2025-04-27 20:36:26 +02:00
CWX 7c7297f63c Code cleanup and format 2025-04-22 14:49:05 +01:00
CWX 8ba498a4bc Removed TraderAssortService use TraderHelper.GetTraderAssortsByTraderId 2025-04-22 14:36:28 +01:00
Chomp 6faa69964d Improved comments inside GetSizeByInventoryItemHash and string comparisons 2025-04-20 19:00:52 +01:00
Chomp 118721c436 Rewrote LocateSlot 2025-04-20 17:04:46 +01:00