Replaced various string.toLower() == x checks with string.Equals

This commit is contained in:
Chomp
2025-05-05 14:03:57 +01:00
parent e30d620c44
commit ae98f57bd9
20 changed files with 27 additions and 26 deletions
@@ -34,7 +34,7 @@ public abstract class AbstractDialogChatBot(
return commandos.FirstOrDefault().Handle(splitCommand[1], GetChatBot(), sessionId, request);
}
if (splitCommand.FirstOrDefault()?.ToLower() == "help")
if (string.Equals(splitCommand.FirstOrDefault(), "help", StringComparison.OrdinalIgnoreCase))
{
return SendPlayerHelpMessage(sessionId, request);
}
@@ -85,7 +85,7 @@ public class ProfileSptCommand(
{
var enumSkill = Enum.GetValues<SkillTypes>()
.Cast<SkillTypes?>()
.FirstOrDefault(t => t?.ToString().ToLower() == skill
.FirstOrDefault(t => string.Equals(t?.ToString(), skill, StringComparison.OrdinalIgnoreCase)
);
if (enumSkill == null)
@@ -18,7 +18,7 @@ public class AreYouABotMessageHandler(
public bool CanHandle(string message)
{
return message.ToLower() == "are you a bot";
return string.Equals(message, "are you a bot", StringComparison.OrdinalIgnoreCase);
}
public void Process(string sessionId, UserDialogInfo sptFriendUser, PmcData? sender, object? extraInfo = null)
@@ -16,7 +16,7 @@ public class FishMessageHandler(
public bool CanHandle(string message)
{
return message.ToLower() == "fish";
return string.Equals(message, "fish", StringComparison.OrdinalIgnoreCase);
}
public void Process(string sessionId, UserDialogInfo sptFriendUser, PmcData? sender, object? extraInfo = null)
@@ -21,7 +21,7 @@ public class ForceChristmasMessageHandler(
public bool CanHandle(string message)
{
return message.ToLower() == "hohoho";
return string.Equals(message, "hohoho", StringComparison.OrdinalIgnoreCase);
}
public void Process(string sessionId, UserDialogInfo sptFriendUser, PmcData? sender, object? extraInfo = null)
@@ -21,7 +21,7 @@ public class ForceHalloweenMessageHandler(
public bool CanHandle(string message)
{
return message.ToLower() == "veryspooky";
return string.Equals(message, "veryspooky", StringComparison.OrdinalIgnoreCase);
}
public void Process(string sessionId, UserDialogInfo sptFriendUser, PmcData? sender, object? extraInfo = null)
@@ -25,7 +25,7 @@ public class ForceSnowMessageHandler(
public bool CanHandle(string message)
{
return message.ToLower() == "itsonlysnowalan";
return string.Equals(message, "itsonlysnowalan", StringComparison.OrdinalIgnoreCase);
}
public void Process(string sessionId, UserDialogInfo sptFriendUser, PmcData? sender, object? extraInfo = null)
@@ -25,7 +25,7 @@ public class ForceSummerMessageHandler(
public bool CanHandle(string message)
{
return message.ToLower() == "givemesunshine";
return string.Equals(message, "givemesunshine", StringComparison.OrdinalIgnoreCase);
}
public void Process(string sessionId, UserDialogInfo sptFriendUser, PmcData? sender, object? extraInfo = null)
@@ -18,7 +18,7 @@ public class GarbageMessageHandler(
public bool CanHandle(string message)
{
return message.ToLower() == "garbage";
return string.Equals(message, "garbage", StringComparison.OrdinalIgnoreCase);
}
public void Process(string sessionId, UserDialogInfo sptFriendUser, PmcData? sender, object? extraInfo = null)
@@ -25,7 +25,7 @@ public class GiveMeSpaceMessageHandler(
public bool CanHandle(string message)
{
return message.ToLower() == "givemespace";
return string.Equals(message, "givemespace", StringComparison.OrdinalIgnoreCase);
}
public void Process(string sessionId, UserDialogInfo sptFriendUser, PmcData? sender, object? extraInfo = null)
@@ -19,7 +19,7 @@ public class LoveYouChatMessageHandler(
public bool CanHandle(string message)
{
return message.ToLower() == "love you";
return string.Equals(message, "love you", StringComparison.OrdinalIgnoreCase);
}
public void Process(string sessionId, UserDialogInfo sptFriendUser, PmcData? sender, object? extraInfo = null)
@@ -18,7 +18,7 @@ public class NikitaMessageHandler(
public bool CanHandle(string message)
{
return message.ToLower() == "nikita";
return string.Equals(message, "nikita", StringComparison.OrdinalIgnoreCase);
}
public void Process(string sessionId, UserDialogInfo sptFriendUser, PmcData? sender, object? extraInfo = null)
@@ -18,7 +18,7 @@ public class SptMessageHandler(
public bool CanHandle(string message)
{
return message.ToLower() == "spt";
return string.Equals(message, "spt", StringComparison.OrdinalIgnoreCase);
}
public void Process(string sessionId, UserDialogInfo sptFriendUser, PmcData? sender, object? extraInfo = null)
@@ -47,7 +47,7 @@ public class SptDialogueChatBot(
var sender = _profileHelper.GetPmcProfile(sessionId);
var sptFriendUser = GetChatBot();
if (request.Text?.ToLower() == "help")
if (string.Equals(request.Text, "help", StringComparison.OrdinalIgnoreCase))
{
return SendPlayerHelpMessage(sessionId, request);
}
@@ -97,7 +97,7 @@ public class LocaleService(
/// <returns> Locale e.g en/ge/cz/cn </returns>
public string GetDesiredGameLocale()
{
if (_localeConfig.GameLocale.ToLower() == "system")
if (string.Equals(_localeConfig.GameLocale, "system", StringComparison.OrdinalIgnoreCase))
{
return GetPlatformForClientLocale();
}
@@ -112,7 +112,7 @@ public class LocaleService(
/// <returns> Locale e.g en/ge/cz/cn </returns>
public string GetDesiredServerLocale()
{
if (_localeConfig.ServerLocale.ToLower() == "system")
if (string.Equals(_localeConfig.ServerLocale, "system", StringComparison.OrdinalIgnoreCase))
{
return GetPlatformForServerLocale();
}
@@ -209,7 +209,7 @@ public class LocationLifecycleService
/// <param name="locationData"> Maps location base data </param>
protected void AdjustExtracts(string playerSide, string location, LocationBase locationData)
{
var playerIsScav = playerSide.ToLower() == "savage";
var playerIsScav = string.Equals(playerSide, "savage", StringComparison.OrdinalIgnoreCase);
if (!playerIsScav)
{
return;
@@ -225,7 +225,7 @@ public class LocationLifecycleService
}
// Find only scav extracts and overwrite existing exits with them
var scavExtracts = mapExtracts.Where(extract => extract.Side.ToLower() == "scav").ToList();
var scavExtracts = mapExtracts.Where(extract => string.Equals(extract.Side, "scav", StringComparison.OrdinalIgnoreCase)).ToList();
if (scavExtracts.Count > 0)
// Scav extracts found, use them
{
@@ -347,7 +347,7 @@ public class LocationLifecycleService
locationBaseClone.UnixDateTime = _timeUtil.GetTimeStamp();
// Don't generate loot for hideout
if (name.ToLower() == "hideout")
if (string.Equals(name, "hideout", StringComparison.OrdinalIgnoreCase))
{
return locationBaseClone;
}
@@ -167,7 +167,7 @@ public class ProfileFixerService(
// Iterate over clothing
var customizationDb = _databaseService.GetTemplates().Customization;
var customizationDbArray = customizationDb.Values;
var playerIsUsec = pmcProfile.Info.Side.ToLower() == "usec";
var playerIsUsec = string.Equals(pmcProfile.Info.Side, "usec", StringComparison.OrdinalIgnoreCase);
// Check Head
if (customizationDb[pmcProfile.Customization.Head] is null)
@@ -151,7 +151,7 @@ public class RaidTimeAdjustmentService(
};
// Pmc raid, send default
if (request.Side.ToLower() == "pmc")
if (string.Equals(request.Side, "pmc", StringComparison.OrdinalIgnoreCase))
{
return result;
}
@@ -714,7 +714,8 @@ public class SeasonalEventService(
/// </summary>
protected void AdjustZryachiyMeleeChance()
{
var zryachiyKvP = _databaseService.GetBots().Types.FirstOrDefault(x => x.Key.ToLower() == "bosszryachiy");
var zryachiyKvP = _databaseService.GetBots().Types
.FirstOrDefault(x => string.Equals(x.Key, "bosszryachiy", StringComparison.OrdinalIgnoreCase));
var value = new Dictionary<string, double>();
foreach (var chance in zryachiyKvP.Value.BotChances.EquipmentChances)
+4 -4
View File
@@ -374,10 +374,10 @@ public class ModValidator(
var modName = mod.PackageJson.Name;
var modPath = GetModPath(modName);
var modIsCalledBepinEx = modName.ToLower() == "bepinex";
var modIsCalledUser = modName.ToLower() == "user";
var modIsCalledSrc = modName.ToLower() == "src";
var modIsCalledDb = modName.ToLower() == "db";
var modIsCalledBepinEx = string.Equals(modName, "bepinex", StringComparison.OrdinalIgnoreCase);
var modIsCalledUser = string.Equals(modName, "user", StringComparison.OrdinalIgnoreCase);
var modIsCalledSrc = string.Equals(modName, "src", StringComparison.OrdinalIgnoreCase);
var modIsCalledDb = string.Equals(modName, "db", StringComparison.OrdinalIgnoreCase);
var hasBepinExFolderStructure = fileUtil.DirectoryExists($"{mod.Directory}/plugins");
var containsJs = fileUtil.GetFiles(mod.Directory, true, "*.js").Count > 0;
var containsTs = fileUtil.GetFiles(mod.Directory, true, "*.ts").Count > 0;