287 Commits

Author SHA1 Message Date
Chomp 8573e6ae02 Use string.empty and MongoId.Empty() where appropriate 2025-08-17 21:35:34 +01:00
sp-tarkov-bot ab114352ea Format Style Fixes 2025-08-16 23:31:11 +00:00
Chomp 3c8634edd7 Improved saftey of adjusting values when using randomistionDetails.NighttimeChanges.EquipmentModsModifiers 2025-08-16 14:38:02 +01:00
Chomp d94490b52f Added functionality to force PMCs to wear specific armband - default enabled
usec = blue
bear = red
2025-08-16 14:37:06 +01:00
Chomp 07504d406e Renamed TryFillContainerMapWithItem and changed output to better follow c# conventions 2025-08-15 11:24:10 +01:00
Chomp b061200803 Refactor of how bot loot has its position picked to improve performance (#548)
* Initial work on moving container space checks into new class

* Updated tests

Wired up service to save item into inventory when space is found

Updated `FillContainerMapWithItem` to return outcome and not throw exception on failure

Add containers to bot when generating bot equipment

Clean bot cache after completion of loot generation

Removed redundant code from `AddItemWithChildrenToEquipmentSlot`

Removed unnecessary Singleton status from `BotInventoryContainerService`

* Clean-up of service

* Add botId xml docs

* Updated documentation for `FillContainerMapWithItem`

* Code review fixes and improvements

* Remove TODO

---------

Co-authored-by: Chomp <dev@dev.sp-tarkov.com>
2025-08-13 15:35:57 +00:00
Cj 0964acff8d Fix bad port from node, fix invalid specific extract requirement 2025-08-12 16:13:39 -04:00
Jesse 60958b3d24 Merge pull request #544 from sp-tarkov/remove-warnings
Remove unused dependencies and improve code quality
2025-08-12 19:26:05 +02:00
Cj e54dcbd4d1 Fix more warnings... (#543)
* Fix more warnings...

* Fix mistake
2025-08-12 15:28:54 +00:00
Cj 9bd5c2a401 Prefer fallthrough over or and newline 2025-08-11 14:08:59 -04:00
sp-tarkov-bot 1474d2b799 Format Style Fixes 2025-08-11 14:13:49 +00:00
Cj 76e91047d6 More warnings fixes (#542)
* Fix more warnings, add new exception

* Run formatter

---------

Co-authored-by: Chomp <27521899+chompDev@users.noreply.github.com>
2025-08-11 14:13:02 +00:00
Archangel dd67098734 Remove unnecessary cloning 2025-08-09 16:53:05 +02:00
Lacyway d468848b0c Improve MongoIds (#537)
* Mongoid improvements pt1

* Format Style Fixes

* Fix incorrect string

* Fix != comparison

---------

Co-authored-by: sp-tarkov-bot <singleplayertarkov@gmail.com>
2025-08-09 11:50:49 +01:00
Chomp 2df90e2a1e Removed unnecessary dupe check from fence base assort generation 2025-08-08 12:35:38 +01:00
Chomp dea94255e4 Bot generation performance improvements
Trader assort generation performance improvements

Removed use of recursion inside `FindAndReturnChildrenByAssort`
Created extension method `CreateParentIdLookupCache`
2025-08-08 12:33:31 +01:00
Chomp f35d56e5f0 Improved logic inside IsWeaponValid()
made use of lookup table to improve performance
Skip checking mods with 0 required slots
2025-08-06 21:18:47 +01:00
Chomp a8702c9cdf Improved logic inside GenerateBotLevel 2025-08-06 21:17:12 +01:00
Chomp 6b297adf68 Replaced ProbabilityObjectArray.Draw() with DrawAndRemove Draw
Reduced overhead when drawing a large number of elements during loot generation
2025-08-06 17:52:49 +01:00
Chomp 8e961633d4 string > mongoId conversion 2025-08-06 15:22:37 +01:00
Archangel d78e8af42c Remove additional cloner 2025-08-06 15:34:21 +02:00
Archangel 8a4f2a297b Remove loot cloners and make LazyLoad return a new result each request 2025-08-06 15:33:11 +02:00
Chomp cdc9cd59e2 Replaced Wishlist property in profile with pure dictionary 2025-08-06 12:47:28 +01:00
Chomp 3b4bcaf910 Made use of AddUpd extension 2025-08-05 15:56:23 +01:00
Chomp e7fd757dce Improved how bots are generated to be less blocking
Updated `GenerateBotWaves` to return empty results when request data is empty

Cleaned up `GenerateBotWave` to not need a manual lock
Improved `botRelativeLevelDelta` value in pmc.config

Updated `MatchBotDetailsCacheService` to store PMCs primary weapon tpl
2025-08-04 13:25:19 +01:00
Chomp 08815da10d Improved Fake PMC offer count fluctuations #527
Added fake PMC offer count index to `RagfairOfferHolder` and made use of it when checking if offer count is over desired count
2025-08-02 11:22:27 +01:00
Archangel aec8420d53 Cleanup todos, run VS cleanup & enforce file scoped namespacing 2025-07-31 15:18:20 +02:00
sp-tarkov-bot 05c097e044 Format Style Fixes 2025-07-30 15:56:15 +00:00
Chomp fcf7a6d40f Removed unused side_plate weights from config
Reduced code duplication in `FilterPlateModsForSlotByLevel`
2025-07-30 16:55:26 +01:00
Chomp 2a56f3811c Updated LocationLootGenerator ctor parameter formatting 2025-07-28 23:02:35 +01:00
Chomp a72860e33a Small cleanup to loop inside GenerateStaticContainers 2025-07-28 22:24:27 +01:00
sp-tarkov-bot b14b74bf24 Format Style Fixes 2025-07-28 19:39:29 +00:00
Chomp 9db4f65002 forgot a file 2025-07-28 15:11:05 +01:00
Chomp 623fce1484 Added id generation for BaseClasses, updated references 2025-07-27 17:40:27 +01:00
Chomp 85b47f494e Made ammo not require Found in Raid for daily quests #401 2025-07-27 16:31:29 +01:00
Chomp 83cb707551 Updated comment styles 2025-07-27 12:56:09 +01:00
Chomp bfd616e7c3 Converted rewards data into dictionary - reduced need for reflection
Moved clone outside of `UpdateQuestsForGameEdition`
2025-07-26 12:53:56 +01:00
Chomp b1aa8f0942 Removed unnecessary ?? 2025-07-25 20:09:07 +01:00
Chomp ab770e795f Improved stale offer processing
Pass offer creation info into methods for quicker checking

Removed unused methods
2025-07-25 12:41:41 +01:00
Chomp 34bd002876 list to ienumerable changes
Removed unused methods

strong to mongoId changes
2025-07-25 12:28:40 +01:00
Archangel 384381f57e Make ItemLacksSlotsCartridgesAndChambers more robust, migrate to extension 2025-07-24 22:46:23 +02:00
Chomp 1f6231ce6b Improved readability of GetRelativePmcBotLevelRange 2025-07-24 18:16:13 +01:00
sp-tarkov-bot 68f95db26a .NET Format Style Fixes 2025-07-24 15:05:49 +00:00
Chomp 2c5420f3db list to ienumerable 2025-07-24 16:05:14 +01:00
sp-tarkov-bot 99a4b7cbba .NET Format Style Fixes 2025-07-24 12:27:13 +00:00
Chomp f562c634a7 Converted lists to hashsets where appropriate
Removed unnecessary uses of  ToList()
string to mongoId conversions
2025-07-24 13:26:34 +01:00
Chomp 6079e282f5 List to ienumerable conversions 2025-07-24 11:36:42 +01:00
sp-tarkov-bot 95420acd3d .NET Format Style Fixes 2025-07-24 08:40:50 +00:00
Chomp e77e910cd4 Cleaned up ItemFilterService:
Removed dupe methods
Removed use of clone
Added `AddItemToBlacklistCache` and `AddItemToLootableBlacklistCache`
2025-07-24 09:40:17 +01:00
Chomp 10ad2dfe9a list to ienumerable changes 2025-07-23 22:07:56 +01:00