Improved IsValidMongoIdTest

2025-01-29 13:30:31 +00:00
parent 9ddeb1f363
commit 06bfa78a62
1 changed files with 9 additions and 24 deletions
@@ -29,30 +29,15 @@ public class HashUtilTests
 	}
 	
 	[TestMethod]
-	public void IsValidMongoIdTest()
+    [DataRow("677ddb67406e9918a0264bbz", false, "677ddb67406e9918a0264bbz contains invalid char `z`, but result was true")]
+    [DataRow("677ddb67406e9918a0264bbcc", false, "677ddb67406e9918a0264bbcc is 25 characters, but result was true")]
+    [DataRow("677ddb67406e9918a0264bbc", true, "IsValidMongoId() `677ddb67406e9918a0264bbc` is a valid mongoId, but result was false")]
+public void IsValidMongoIdTest(string mongoId, bool passes, string failMessage)
 	{
-		// Invalid mongoId character
-		var ResultBadChar = _hashUtil.IsValidMongoId("677ddb67406e9918a0264bbz");
-		
-		Assert.AreEqual(
-			false, 
-			ResultBadChar,
-			"IsValidMongoId() `677ddb67406e9918a0264bbz` contains invalid char `z`, but result was true");
-		
-		// Invalid mongoId length
-		var resultBadLength = _hashUtil.IsValidMongoId("677ddb67406e9918a0264bbcc");
-		
-		Assert.AreEqual(
-			false, 
-			resultBadLength,
-			"IsValidMongoId() `677ddb67406e9918a0264bbcc` is 25 characters, but result was true");
-		
-		// Valid mongoId
-		var resultPass = _hashUtil.IsValidMongoId("677ddb67406e9918a0264bbc");
-		
-		Assert.AreEqual(
-			true, 
-			resultPass,
-			"IsValidMongoId() `677ddb67406e9918a0264bbc` is a valid mongoId, but result was false");
+        var result = _hashUtil.IsValidMongoId(mongoId);
+        Assert.AreEqual(
+            passes,
+            result,
+            failMessage);
 	}
 }