From 06bfa78a627dc67795f15b6e229be8b232368ab6 Mon Sep 17 00:00:00 2001
From: Chomp <dev@dev.sp-tarkov.com>
Date: Wed, 29 Jan 2025 13:30:31 +0000
Subject: [PATCH] Improved `IsValidMongoIdTest`

---
 UnitTests/Tests/Utils/HashUtilTests.cs | 33 +++++++-------------------
 1 file changed, 9 insertions(+), 24 deletions(-)

diff --git a/UnitTests/Tests/Utils/HashUtilTests.cs b/UnitTests/Tests/Utils/HashUtilTests.cs
index e685cbbb..c56f1d6a 100644
--- a/UnitTests/Tests/Utils/HashUtilTests.cs
+++ b/UnitTests/Tests/Utils/HashUtilTests.cs
@@ -29,30 +29,15 @@ public class HashUtilTests
 	}
 	
 	[TestMethod]
-	public void IsValidMongoIdTest()
+    [DataRow("677ddb67406e9918a0264bbz", false, "677ddb67406e9918a0264bbz contains invalid char `z`, but result was true")]
+    [DataRow("677ddb67406e9918a0264bbcc", false, "677ddb67406e9918a0264bbcc is 25 characters, but result was true")]
+    [DataRow("677ddb67406e9918a0264bbc", true, "IsValidMongoId() `677ddb67406e9918a0264bbc` is a valid mongoId, but result was false")]
+public void IsValidMongoIdTest(string mongoId, bool passes, string failMessage)
 	{
-		// Invalid mongoId character
-		var ResultBadChar = _hashUtil.IsValidMongoId("677ddb67406e9918a0264bbz");
-		
-		Assert.AreEqual(
-			false, 
-			ResultBadChar,
-			"IsValidMongoId() `677ddb67406e9918a0264bbz` contains invalid char `z`, but result was true");
-		
-		// Invalid mongoId length
-		var resultBadLength = _hashUtil.IsValidMongoId("677ddb67406e9918a0264bbcc");
-		
-		Assert.AreEqual(
-			false, 
-			resultBadLength,
-			"IsValidMongoId() `677ddb67406e9918a0264bbcc` is 25 characters, but result was true");
-		
-		// Valid mongoId
-		var resultPass = _hashUtil.IsValidMongoId("677ddb67406e9918a0264bbc");
-		
-		Assert.AreEqual(
-			true, 
-			resultPass,
-			"IsValidMongoId() `677ddb67406e9918a0264bbc` is a valid mongoId, but result was false");
+        var result = _hashUtil.IsValidMongoId(mongoId);
+        Assert.AreEqual(
+            passes,
+            result,
+            failMessage);
 	}
 }