Cj
bb649e6748
Warning fixes and ProfileValidatorHelper cleanup ( #551 )
...
* Fix warnings in ProfileHelper.cs
* Refactor ProfileValidatorHelper.cs
* reduce nesting
2025-08-15 11:29:46 +00:00
Chomp
07504d406e
Renamed TryFillContainerMapWithItem and changed output to better follow c# conventions
2025-08-15 11:24:10 +01:00
Chomp
b061200803
Refactor of how bot loot has its position picked to improve performance ( #548 )
...
* Initial work on moving container space checks into new class
* Updated tests
Wired up service to save item into inventory when space is found
Updated `FillContainerMapWithItem` to return outcome and not throw exception on failure
Add containers to bot when generating bot equipment
Clean bot cache after completion of loot generation
Removed redundant code from `AddItemWithChildrenToEquipmentSlot`
Removed unnecessary Singleton status from `BotInventoryContainerService`
* Clean-up of service
* Add botId xml docs
* Updated documentation for `FillContainerMapWithItem`
* Code review fixes and improvements
* Remove TODO
---------
Co-authored-by: Chomp <dev@dev.sp-tarkov.com >
2025-08-13 15:35:57 +00:00
Chomp
2d780eb791
Fixed GetLootFromCache filtering out valid loot items
2025-08-13 12:41:29 +01:00
Jesse
60958b3d24
Merge pull request #544 from sp-tarkov/remove-warnings
...
Remove unused dependencies and improve code quality
2025-08-12 19:26:05 +02:00
Cj
e54dcbd4d1
Fix more warnings... ( #543 )
...
* Fix more warnings...
* Fix mistake
2025-08-12 15:28:54 +00:00
Chomp
4a081a7ac3
Updated class param formatting
2025-08-11 21:08:55 +01:00
Archangel
860daee674
Improve prestige quest handling if quest does not exist
2025-08-11 15:41:49 +02:00
Chomp
6ad88a3c7a
Improved item lookup safety inside FixShotgunDispersions
2025-08-09 11:53:03 +01:00
Lacyway
d468848b0c
Improve MongoIds ( #537 )
...
* Mongoid improvements pt1
* Format Style Fixes
* Fix incorrect string
* Fix != comparison
---------
Co-authored-by: sp-tarkov-bot <singleplayertarkov@gmail.com >
2025-08-09 11:50:49 +01:00
Chomp
0b91250c3d
Used single TryGetValue instead of ContainsKey + direct access
2025-08-08 15:57:30 +01:00
Chomp
2f962ef6dc
string to mongoId conversion
2025-08-07 15:08:37 +01:00
Chomp
cdc9cd59e2
Replaced Wishlist property in profile with pure dictionary
2025-08-06 12:47:28 +01:00
Archangel
c3b36f4c7d
Handle invalid profiles on all IOnUpdate
2025-08-05 17:20:49 +02:00
Chomp
3b4bcaf910
Made use of AddUpd extension
2025-08-05 15:56:23 +01:00
Jesse
c7e40deb90
Add support for partially loading invalid profiles ( #533 )
...
* Add support for partially loading invalid profiles
* Return early in exception
2025-08-05 15:25:47 +01:00
Chomp
98eae09034
Simplified logic inside ContainsActiveProfile and added comments
2025-08-05 13:53:17 +01:00
Archangel
be289d590d
Remove unecessary casting, handle sorting migrations in extension
2025-08-05 04:10:13 +02:00
Archangel
0b250161be
If profile can't be loaded log the exception and throw
2025-08-05 03:51:18 +02:00
Chomp
3276c45e57
Hideout slot size check safety improvements
2025-08-04 19:17:26 +01:00
Chomp
443878e75a
Cleaned up CheckForOrphanedModdedItems
...
Now deletes modded child items
Fixed values not being logged correctly
Only log error message once instead of for every invalid item, players don't read it anyway
2025-08-04 19:16:35 +01:00
Chomp
f4210a3d15
Fixed Collection was modified exception inside CheckForOrphanedModdedItems
2025-08-04 17:55:19 +01:00
Archangel
4c66cbef36
Handle failed non restartable quests better
2025-08-04 16:22:12 +02:00
Chomp
9793cd25ed
Improved key lookup inside ProcessPostRaidQuests()
2025-08-04 13:38:56 +01:00
Chomp
e7fd757dce
Improved how bots are generated to be less blocking
...
Updated `GenerateBotWaves` to return empty results when request data is empty
Cleaned up `GenerateBotWave` to not need a manual lock
Improved `botRelativeLevelDelta` value in pmc.config
Updated `MatchBotDetailsCacheService` to store PMCs primary weapon tpl
2025-08-04 13:25:19 +01:00
Chomp
0ea5269756
Updated profile SkillTypes property to use string to enum converter
...
Updated surrounding properties to not be null
Updated related code to reflect nullability change
2025-08-03 09:52:18 +01:00
Archangel
cec47fefd2
Apply enforced file scoped namespacing
2025-07-31 15:23:32 +02:00
Archangel
aec8420d53
Cleanup todos, run VS cleanup & enforce file scoped namespacing
2025-07-31 15:18:20 +02:00
Jesse
fc7660b6c8
Slight bundle & fileutil refactor: ( #524 )
...
- Actually load the bundle cache file now
- Don't read file as string with StreamReader, instead read with ReadAllTextAsync
- Slight refactor to bundle hashing
Co-authored-by: Chomp <27521899+chompDev@users.noreply.github.com >
2025-07-30 22:23:29 +00:00
Chomp
c89c84dff3
Converted RemoveFiRStatusFromItemsInContainer into extension method
...
Improved performance of method by using breadth-first search to find children instead of loop
Wrote tests for method
2025-07-30 23:13:09 +01:00
Chomp
357c2f5dac
Created EndRaidResultExtensions
2025-07-30 17:30:50 +01:00
Jesse
bf5dedb672
Add currently active client mods in ProfileActivityService ( #523 )
...
* Add currently active client mods in ProfileActivityService
* Add method to fetch active client mods on profile
2025-07-28 21:18:38 +00:00
sp-tarkov-bot
b14b74bf24
Format Style Fixes
2025-07-28 19:39:29 +00:00
Chomp
623fce1484
Added id generation for BaseClasses, updated references
2025-07-27 17:40:27 +01:00
R3ality
08a279c4e4
Fix typo in cultistCircle.craftTimeThreshholds
2025-07-27 11:38:12 +03:00
Chomp
bfd616e7c3
Converted rewards data into dictionary - reduced need for reflection
...
Moved clone outside of `UpdateQuestsForGameEdition`
2025-07-26 12:53:56 +01:00
Chomp
8aff434933
Merge pull request #517 from CJ-SPT/skill-fix
...
Fix sending invalid skill information to client
2025-07-26 09:32:56 +00:00
Chomp
56a6bde1e1
Refactored how fence assorts are generated
...
Removed root items from pool as they're picked
Removed unnecessary ToList()
Added exit when there's no more root items to pick
2025-07-26 10:29:15 +01:00
Cj
a9c20e57a3
Check skills when sending profile to client
2025-07-26 00:24:48 -04:00
Chomp
40b478b08c
Revert debug logging
2025-07-25 22:33:35 +01:00
Chomp
526c3f6c44
string > mongoid
...
added nullguard
2025-07-25 21:12:37 +01:00
Chomp
6209f55baf
Simplified .Contains/.Add use
2025-07-25 20:19:29 +01:00
Chomp
5cfb1421c7
Removed unnecessary ??
2025-07-25 20:13:50 +01:00
Chomp
b1aa8f0942
Removed unnecessary ??
2025-07-25 20:09:07 +01:00
Chomp
834666a403
Created overload of ItemHasBaseClass that accepts one base type input, faster for 70% of use cases
2025-07-25 17:22:59 +01:00
Chomp
457a135a91
Improved performance of root node check by caching root nodes as hashset
2025-07-25 15:58:52 +01:00
Chomp
ab770e795f
Improved stale offer processing
...
Pass offer creation info into methods for quicker checking
Removed unused methods
2025-07-25 12:41:41 +01:00
Chomp
34bd002876
list to ienumerable changes
...
Removed unused methods
strong to mongoId changes
2025-07-25 12:28:40 +01:00
Chomp
5802468505
Fixed selling item from container to fence error
...
Updated items param to be ienumerable
2025-07-24 16:09:04 +01:00
Chomp
2c5420f3db
list to ienumerable
2025-07-24 16:05:14 +01:00