Commit Graph

2199 Commits

Author SHA1 Message Date
Jesse 60958b3d24 Merge pull request #544 from sp-tarkov/remove-warnings
Remove unused dependencies and improve code quality
2025-08-12 19:26:05 +02:00
Archangel a8f43a70f7 Update docs 2025-08-12 18:34:26 +02:00
Cj d705b6119a Fix incomplete error text 2025-08-12 11:52:33 -04:00
Cj e54dcbd4d1 Fix more warnings... (#543)
* Fix more warnings...

* Fix mistake
2025-08-12 15:28:54 +00:00
Chomp 4a081a7ac3 Updated class param formatting 2025-08-11 21:08:55 +01:00
Cj 2704998768 Change missed switch to fallthrough over or 2025-08-11 14:12:44 -04:00
Cj 9bd5c2a401 Prefer fallthrough over or and newline 2025-08-11 14:08:59 -04:00
sp-tarkov-bot 1474d2b799 Format Style Fixes 2025-08-11 14:13:49 +00:00
Cj 76e91047d6 More warnings fixes (#542)
* Fix more warnings, add new exception

* Run formatter

---------

Co-authored-by: Chomp <27521899+chompDev@users.noreply.github.com>
2025-08-11 14:13:02 +00:00
Archangel 860daee674 Improve prestige quest handling if quest does not exist 2025-08-11 15:41:49 +02:00
Chomp e7376a7cf3 Updated server locales 2025-08-10 17:02:59 +01:00
Chomp 982878cd95 Removed unused helper method 2025-08-10 12:17:05 +01:00
Chomp 8bc25ca4eb Fix most warnings inside ItemHelper.cs (#541) 2025-08-10 11:15:06 +00:00
Cj 8b4a81fae7 Make first 3 initial daily quests of differing type (#540)
* Make first 3 initial daily quests of differing type

* add comment
2025-08-10 09:52:00 +01:00
Cj 4b02b6de7d Fix most warnings inside ItemHelper.cs 2025-08-10 00:09:44 -04:00
sp-tarkov-bot a4995b7318 Format Style Fixes 2025-08-09 20:41:17 +00:00
Cj 4d0eb4d4f3 Change to using builtin SemVer type for AbstractModMetadata and ProgramStatistics.Generated (#536)
* Change to using SemVer builtin type

* Remove SptVersion from config, remove redundant .ToString()

* Update test mod, fix watermark string conversion
2025-08-09 20:40:25 +00:00
Archangel dd67098734 Remove unnecessary cloning 2025-08-09 16:53:05 +02:00
Archangel fbb0e6cd6a Add configurable build text colors 2025-08-09 14:57:07 +02:00
sp-tarkov-bot 39118c9d56 Format Style Fixes 2025-08-09 12:49:25 +00:00
Archangel 59fca768be Make lists readonly and do not assign unecessary vars 2025-08-09 14:48:24 +02:00
sp-tarkov-bot 28f84663f8 Format Style Fixes 2025-08-09 12:46:06 +00:00
Archangel 1065c80f48 Remove nodisms from WatermarkLocale 2025-08-09 14:45:19 +02:00
Archangel 96a62c20a7 Make Watermark use primary constructor 2025-08-09 14:38:50 +02:00
Archangel 744bb7af74 Make versionLabel more clear 2025-08-09 14:32:01 +02:00
Archangel a46cb06ddb Fix up formatting of version tag 2025-08-09 14:26:12 +02:00
Lacyway 6094449903 Fix handins using from key 2025-08-09 13:49:23 +02:00
Chomp 07ccbaf3ce Fixed repeatable quests not grouping sandbox/sandbox_high together like we do with factory day/night 2025-08-09 12:12:50 +01:00
Chomp 6ad88a3c7a Improved item lookup safety inside FixShotgunDispersions 2025-08-09 11:53:03 +01:00
Chomp 67f7b762e8 Improved profile lookup safety of IsProfileInvalidOrUnloadable 2025-08-09 11:51:47 +01:00
Lacyway d468848b0c Improve MongoIds (#537)
* Mongoid improvements pt1

* Format Style Fixes

* Fix incorrect string

* Fix != comparison

---------

Co-authored-by: sp-tarkov-bot <singleplayertarkov@gmail.com>
2025-08-09 11:50:49 +01:00
Archangel f3134dec59 Fix up BLEEDING_EDGE not being semver compliant 2025-08-08 22:48:09 +02:00
Alex 59e164b740 Dependency reshuffle 2025-08-08 21:06:39 +01:00
Chomp 67bd1c69f6 Corrected comment 2025-08-08 15:57:49 +01:00
Chomp 0b91250c3d Used single TryGetValue instead of ContainsKey + direct access 2025-08-08 15:57:30 +01:00
Chomp 2df90e2a1e Removed unnecessary dupe check from fence base assort generation 2025-08-08 12:35:38 +01:00
Chomp dea94255e4 Bot generation performance improvements
Trader assort generation performance improvements

Removed use of recursion inside `FindAndReturnChildrenByAssort`
Created extension method `CreateParentIdLookupCache`
2025-08-08 12:33:31 +01:00
Chomp 5e05049669 Refactored GetDisplayableAssorts for clarity
Moved slow operations closer to their use inside `IsDisplayableOffer`
2025-08-07 23:24:23 +01:00
Chomp 15023f2e27 Optimised flea searching hotpath 2025-08-07 22:28:36 +01:00
Chomp 809310240c Added TODO 2025-08-07 18:22:28 +01:00
Chomp 162ce3f1d5 Comment and nullguard improvements in HideoutController 2025-08-07 18:22:13 +01:00
Chomp 131f2feeab Added nullguard to RemoveExpiredItemsFromMessage + chagned parameter to MongoId 2025-08-07 18:16:13 +01:00
Chomp 7168e167df Replaced loop with linq inside GetAllTraderSuits + return IEnumerable 2025-08-07 18:15:18 +01:00
Chomp e5be536269 Moved properties closer to their usage inside ItemAllowedInContainer() + improved nullhguard 2025-08-07 18:12:57 +01:00
Chomp 2f452ca2e0 Improved logic of GetTemplatePriceForItems 2025-08-07 18:11:51 +01:00
Chomp 2f962ef6dc string to mongoId conversion 2025-08-07 15:08:37 +01:00
Chomp efe9472f8b Moved trader info lookup outside of loop - StripLockedLoyaltyAssort 2025-08-07 10:54:09 +01:00
Chomp ccfac42814 Improved performance of GetItemWithChildren()
Reduced number of enumerations of `itemWithChildren` inside AddItemWithChildrenToEquipmentSlot()` by converting children to list at start of method
Applied additional filtering to child items collection inside `GetContainerItemsWithChildren()`
2025-08-06 23:14:32 +01:00
Archangel 3ba47c92dd Set proper SPT version across all projects in build.props 2025-08-06 22:41:16 +02:00
Chomp f35d56e5f0 Improved logic inside IsWeaponValid()
made use of lookup table to improve performance
Skip checking mods with 0 required slots
2025-08-06 21:18:47 +01:00