temp removal of async so exceptions dont get eaten and we can move forward

Libraries/Core/Controllers/TraderController.cs

@@ -101,8 +101,9 @@ public class TraderController(
                     continue;
                 case Traders.FENCE:
                 {
-                    if (_fenceService.NeedsPartialRefresh())
-                        _fenceService.GenerateFenceAssorts();
+                    _logger.Warning($"commented out Fence refresh as not implemented so we can get further");
+                    // if (_fenceService.NeedsPartialRefresh())
+                    //     _fenceService.GenerateFenceAssorts();
 
                     continue;
                 }

Libraries/Core/DI/OnUpdate.cs

@@ -2,6 +2,6 @@ namespace Core.DI;
 
 public interface OnUpdate
 {
-    Task<bool> OnUpdate(long timeSinceLastRun);
+    bool OnUpdate(long timeSinceLastRun);
     string GetRoute();
-}
+}

Libraries/Core/Generators/RagfairOfferGenerator.cs

@@ -140,9 +140,9 @@ public class RagfairOfferGenerator()
     /// Create multiple offers for items by using a unique list of items we've generated previously
     /// </summary>
     /// <param name="expiredOffers">optional, expired offers to regenerate</param>
-    public async Task GenerateDynamicOffers(List<List<Item>> expiredOffers = null)
+    public void GenerateDynamicOffers(List<List<Item>> expiredOffers = null)
     {
-        throw new NotImplementedException();
+        Console.WriteLine($"actually implement me plz: owo: GenerateDynamicOffers");
     }
 
     /// <summary>
@@ -150,7 +150,7 @@ public class RagfairOfferGenerator()
     /// <param name="assortItemWithChildren">Item with its children to process into offers</param>
     /// <param name="isExpiredOffer">is an expired offer</param>
     /// <param name="config">Ragfair dynamic config</param>
-    protected async Task CreateOffersFromAssort(List<Item> assortItemWithChildren, bool isExpiredOffer, Dynamic config)
+    protected void CreateOffersFromAssort(List<Item> assortItemWithChildren, bool isExpiredOffer, Dynamic config)
     {
         throw new NotImplementedException();
     }
@@ -185,7 +185,7 @@ public class RagfairOfferGenerator()
     /// <param name="traderID">Trader to generate offers for</param>
     public void GenerateFleaOffersForTrader(string traderID)
     {
-        throw new NotImplementedException();
+        Console.WriteLine($"actually implement me plz: owo: GenerateFleaOffersForTrader");
     }
 
     /// <summary>

Libraries/Core/Helpers/RagfairOfferHelper.cs

@@ -135,9 +135,9 @@ public class RagfairOfferHelper
      * @param sessionID Session id to process offers for
      * @returns true = complete
      */
-    public bool ProcessOffersOnProfile(string sessionID)
+    public void ProcessOffersOnProfile(string sessionID)
     {
-        throw new NotImplementedException();
+        Console.WriteLine($"actually implement me plz: owo: ProcessOffersOnProfile");
     }
 
     /**

Libraries/Core/Servers/RagfairServer.cs

@@ -40,13 +40,13 @@ namespace Core.Servers
             _ragfairConfig = _configServer.GetConfig<RagfairConfig>();
         }
 
-        public async Task Load(){
+        public void Load(){
             _logger.Info(_localisationService.GetText("ragfair-generating_offers"));
-            await _ragfairOfferGenerator.GenerateDynamicOffers();
-            await Update();
+            _ragfairOfferGenerator.GenerateDynamicOffers(); 
+            Update();
         }
 
-        public async Task Update()
+        public void Update()
         {
             _ragfairOfferService.ExpireStaleOffers();
 
@@ -69,7 +69,7 @@ namespace Core.Servers
             if (_ragfairOfferService.GetExpiredOfferCount() >= _ragfairConfig.Dynamic.ExpiredOfferThreshold)
             {
                 var expiredAssortsWithChildren = _ragfairOfferService.GetExpiredOfferAssorts();
-                await _ragfairOfferGenerator.GenerateDynamicOffers(expiredAssortsWithChildren);
+                _ragfairOfferGenerator.GenerateDynamicOffers(expiredAssortsWithChildren);
 
                 // Clear out expired offers now we've generated them
                 _ragfairOfferService.ResetExpiredOffers();

Libraries/Core/Services/DatabaseService.cs

@@ -22,7 +22,7 @@ public class DatabaseService(
     HashUtil _hashUtil
 )
 {
-    protected bool isDataValid;
+    protected bool isDataValid = true;
     
     /**
      * @returns assets/database/

Libraries/Core/Services/RagfairOfferService.cs

@@ -42,7 +42,8 @@ public class RagfairOfferService
     /// <returns>Number of expired offers</returns>
     public int GetExpiredOfferCount()
     {
-        throw new NotImplementedException();
+        Console.WriteLine($"actually implement me plz: owo: GetExpiredOfferCount");
+        return 0;
     }
 
     /// <summary>
@@ -51,7 +52,8 @@ public class RagfairOfferService
     /// <returns>Expired offer assorts</returns>
     public List<List<Item>> GetExpiredOfferAssorts()
     {
-        throw new NotImplementedException();
+        Console.WriteLine($"actually implement me plz: owo: GetExpiredOfferAssorts");
+        return new List<List<Item>>();
     }
 
     /// <summary>
@@ -59,7 +61,7 @@ public class RagfairOfferService
     /// </summary>
     public void ResetExpiredOffers()
     {
-        throw new NotImplementedException();
+        Console.WriteLine($"actually implement me plz: owo: ResetExpiredOffers");
     }
 
     /// <summary>
@@ -103,17 +105,19 @@ public class RagfairOfferService
     /// <returns>true if they do</returns>
     public bool TraderOffersNeedRefreshing(string traderID)
     {
-        throw new NotImplementedException();
+        Console.WriteLine($"actually implement me plz: owo: TraderOffersNeedRefreshing");
+        return false;
     }
 
     public void AddPlayerOffers()
     {
-        throw new NotImplementedException();
+        Console.WriteLine($"actually implement me plz: owo: AddPlayerOffers");
+        // throw new NotImplementedException();
     }
 
     public void ExpireStaleOffers()
     {
-        throw new NotImplementedException();
+        Console.WriteLine($"actually implement me plz: owo: ExpireStaleOffers");
     }
 
     /// <summary>

Libraries/Core/Services/RagfairRequiredItemsService.cs

@@ -8,11 +8,12 @@ public class RagfairRequiredItemsService
 {
     public List<RagfairOffer> GetRequiredItemsById(string searchId)
     {
-        throw new NotImplementedException();
+        Console.WriteLine($"actually implement me plz: owo: GetRequiredItemsById");
+        return new List<RagfairOffer>();
     }
 
     public void BuildRequiredItemTable()
     {
-        throw new NotImplementedException();
+        Console.WriteLine($"actually implement me plz: owo: BuildRequiredItemTable");
     }
 }