Added clearer check for expired player offers

This commit is contained in:
Chomp
2025-06-23 13:36:26 +01:00
parent 8f4754b047
commit 7511597c9e
2 changed files with 8 additions and 2 deletions
@@ -653,6 +653,12 @@ public class RagfairOfferHelper(
for (var index = profileOffers.Count - 1; index >= 0; index--)
{
var offer = profileOffers[index];
if (currentTimestamp > offer.EndTime)
{
// Offer has expired before selling, skip as it will be processed in RemoveExpiredOffers()
continue;
}
if (
offer.SellResults is null
|| offer.SellResults.Count == 0
@@ -848,7 +854,7 @@ public class RagfairOfferHelper(
};
var storageTimeSeconds = _timeUtil.GetHoursAsSeconds(
(int)_questHelper.GetMailItemRedeemTimeHoursForProfile(sellerProfile)
(int) _questHelper.GetMailItemRedeemTimeHoursForProfile(sellerProfile)
);
_mailSendService.SendDirectNpcMessageToPlayer(
offerOwnerSessionId,
@@ -192,7 +192,7 @@ public class RagfairOfferService(
var isPlayer = profileHelper.IsPlayer(staleOffer.User.Id.RegexReplace("^pmc", ""));
if (flagOfferAsExpired && !isPlayer)
{
// Not trader/player offer
// Not trader or a player offer
ragfairOfferHolder.FlagOfferAsExpired(staleOffer.Id);
}