chillcog/SPT-Server-Build
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed issue with code removing object from collection when iterating over it

Browse Source
This commit is contained in:
Chomp
2025-02-02 12:51:34 +00:00
parent 0f95400b95
commit 38e2a3bb73
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Libraries/Core/Helpers/RagfairOfferHelper.cs
+10 -5
View File
@@ -600,8 +600,10 @@ public class RagfairOfferHelper(
return true;
}
foreach (var offer in profileOffers)
// Index backwards as CompleteOffer() can delete offer object
for (var index = profileOffers.Count - 1; index >= 0; index--)
{
var offer = profileOffers[index];
var firstSellResult = offer.SellResults?.FirstOrDefault();
if (offer.SellResults?.Count > 0 && timestamp >= offer.SellResults[0].SellTime)
{
@@ -620,8 +622,10 @@ public class RagfairOfferHelper(
var ratingToAdd = offer.SummaryCost / totalItemsCount * boughtAmount;
IncreaseProfileRagfairRating(_profileHelper.GetFullProfile(sessionId), ratingToAdd.Value);
offer.SellResults.Remove(firstSellResult); // Remove the sell result object now it has been processed
// Can delete offer object, must run last
CompleteOffer(sessionId, offer, boughtAmount);
offer.SellResults.Remove(firstSellResult);// Remove the sell result object now its been processed
}
}
@@ -716,12 +720,13 @@ public class RagfairOfferHelper(
*/
public ItemEventRouterResponse CompleteOffer(string offerOwnerSessionId, RagfairOffer offer, int boughtAmount)
{
var itemTpl = offer.Items[0].Template;
var rootItem = offer.Items.FirstOrDefault();
var itemTpl = rootItem.Template;
var paymentItemsToSendToPlayer = new List<Item>();
var offerStackCount = offer.Items[0].Upd.StackObjectsCount;
var offerStackCount = rootItem.Upd.StackObjectsCount;
var sellerProfile = _profileHelper.GetPmcProfile(offerOwnerSessionId);
// Pack or ALL items of a multi-offer were bought - remove entire ofer
// Pack or ALL items of a multi-offer were bought - remove entire offer
if (offer.SellInOnePiece.GetValueOrDefault(false) || boughtAmount == offerStackCount)
{
DeleteOfferById(offerOwnerSessionId, offer.Id);