* Initial work on moving container space checks into new class
* Updated tests
Wired up service to save item into inventory when space is found
Updated `FillContainerMapWithItem` to return outcome and not throw exception on failure
Add containers to bot when generating bot equipment
Clean bot cache after completion of loot generation
Removed redundant code from `AddItemWithChildrenToEquipmentSlot`
Removed unnecessary Singleton status from `BotInventoryContainerService`
* Clean-up of service
* Add botId xml docs
* Updated documentation for `FillContainerMapWithItem`
* Code review fixes and improvements
* Remove TODO
---------
Co-authored-by: Chomp <dev@dev.sp-tarkov.com>
Trader assort generation performance improvements
Removed use of recursion inside `FindAndReturnChildrenByAssort`
Created extension method `CreateParentIdLookupCache`
Updated `GenerateBotWaves` to return empty results when request data is empty
Cleaned up `GenerateBotWave` to not need a manual lock
Improved `botRelativeLevelDelta` value in pmc.config
Updated `MatchBotDetailsCacheService` to store PMCs primary weapon tpl
Now allows for per-map multipliers + pocket + vest loot uses same level-based value as backpack
labs multiplier = 2
labyrinth = 4
Removed nullability from some properties
Convert constructors into primary constructors
Simplified logic with use of ??, ??= and method groups
Cleaned up redundant conditional access qualifiers
* chore: Bot generation performance improvements (#227)
* Bot generation performance improvements
* Revert debug logging logic
* Get rid of Info log which is bound to be printed inevitably at each bot wave generation
* Use assault const
* Removed comments
Removed lowercase side constants
Renamed equipment role to better explain its purpose
Fixed `Blocks` property being serialised to client
Updated `_slotsWithNoCompatIssues` to use existing enum type
Reduced log line to be debug
* Fixed `GetRandomTextThatMatchesPartialKey` incorrectly checking eft locales instead of spt locales
* Updated various methods to be protected
---------
Co-authored-by: hulkhan22 <clandestine984@gmail.com>
Co-authored-by: Chomp <dev@dev.sp-tarkov.com>
Chomp
Chomp
sp-tarkov-bot
Cj
Archangel
refringe
Alex
CWX
clodan