60958b3d24
Merge pull request #544 from sp-tarkov/remove-warnings
...
Remove unused dependencies and improve code quality
2025-08-12 19:26:05 +02:00
a8f43a70f7
Update docs
2025-08-12 18:34:26 +02:00
d705b6119a
Fix incomplete error text
2025-08-12 11:52:33 -04:00
e54dcbd4d1
Fix more warnings... ( #543 )
...
* Fix more warnings...
* Fix mistake
2025-08-12 15:28:54 +00:00
4a081a7ac3
Updated class param formatting
2025-08-11 21:08:55 +01:00
2704998768
Change missed switch to fallthrough over or
2025-08-11 14:12:44 -04:00
9bd5c2a401
Prefer fallthrough over or and newline
2025-08-11 14:08:59 -04:00
1474d2b799
Format Style Fixes
2025-08-11 14:13:49 +00:00
76e91047d6
More warnings fixes ( #542 )
...
* Fix more warnings, add new exception
* Run formatter
---------
Co-authored-by: Chomp <27521899+chompDev@users.noreply.github.com >
2025-08-11 14:13:02 +00:00
982878cd95
Removed unused helper method
2025-08-10 12:17:05 +01:00
4b02b6de7d
Fix most warnings inside ItemHelper.cs
2025-08-10 00:09:44 -04:00
d468848b0c
Improve MongoIds ( #537 )
...
* Mongoid improvements pt1
* Format Style Fixes
* Fix incorrect string
* Fix != comparison
---------
Co-authored-by: sp-tarkov-bot <singleplayertarkov@gmail.com >
2025-08-09 11:50:49 +01:00
67bd1c69f6
Corrected comment
2025-08-08 15:57:49 +01:00
dea94255e4
Bot generation performance improvements
...
Trader assort generation performance improvements
Removed use of recursion inside `FindAndReturnChildrenByAssort`
Created extension method `CreateParentIdLookupCache`
2025-08-08 12:33:31 +01:00
5e05049669
Refactored GetDisplayableAssorts for clarity
...
Moved slow operations closer to their use inside `IsDisplayableOffer`
2025-08-07 23:24:23 +01:00
15023f2e27
Optimised flea searching hotpath
2025-08-07 22:28:36 +01:00
e5be536269
Moved properties closer to their usage inside ItemAllowedInContainer() + improved nullhguard
2025-08-07 18:12:57 +01:00
2f452ca2e0
Improved logic of GetTemplatePriceForItems
2025-08-07 18:11:51 +01:00
2f962ef6dc
string to mongoId conversion
2025-08-07 15:08:37 +01:00
efe9472f8b
Moved trader info lookup outside of loop - StripLockedLoyaltyAssort
2025-08-07 10:54:09 +01:00
ccfac42814
Improved performance of GetItemWithChildren()
...
Reduced number of enumerations of `itemWithChildren` inside AddItemWithChildrenToEquipmentSlot()` by converting children to list at start of method
Applied additional filtering to child items collection inside `GetContainerItemsWithChildren()`
2025-08-06 23:14:32 +01:00
654fd63355
Removed unnecessary casts to double
2025-08-06 15:23:11 +01:00
5cd5ed1f42
Refactored logic of ragfairServer.update()
...
typo fixes
2025-08-06 15:17:34 +01:00
98a186ff2f
Refactored logic of GetPmcNicknameOfMaxLength()
2025-08-06 15:15:58 +01:00
7ece60ac54
Improved logic
2025-08-06 12:35:02 +01:00
57dde61384
Various code quality improvements
2025-08-06 12:28:56 +01:00
85a562d1e5
Improved GetRewardProductionMatch logic to make use of saved QuestId property we generate for crafts
2025-08-06 12:27:50 +01:00
83408c76fc
Reduced complexity of GetCompatibleTplFromArray()
...
Flagged ItemHelper as singleton due to number of frozensets
2025-08-05 23:55:13 +01:00
ec2cc78b2a
Inventory code cleanup
2025-08-05 23:48:10 +01:00
8abb25f508
Improved AddItemsToStash
...
Create Add item request once and reassign `ItemWithModsToAdd` inside loop
2025-08-05 23:20:00 +01:00
02b80888ec
Improved dictionary access inside GetItemName to prevent issues where now-removed modded items are checked
2025-08-05 16:27:35 +01:00
529fe61f23
Controller house keeping ( #532 )
...
* Cleanup BotController.cs
* More controller cleanup
* More dialogue changes
2025-08-05 16:24:59 +01:00
3b4bcaf910
Made use of AddUpd extension
2025-08-05 15:56:23 +01:00
c7e40deb90
Add support for partially loading invalid profiles ( #533 )
...
* Add support for partially loading invalid profiles
* Return early in exception
2025-08-05 15:25:47 +01:00
0ea5269756
Updated profile SkillTypes property to use string to enum converter
...
Updated surrounding properties to not be null
Updated related code to reflect nullability change
2025-08-03 09:52:18 +01:00
e1e3ed0bb3
Fixed bots sometimes spawning with 0 stack sized ammo in their pockets/vests #529
2025-08-03 09:34:50 +01:00
aec8420d53
Cleanup todos, run VS cleanup & enforce file scoped namespacing
2025-07-31 15:18:20 +02:00
c89c84dff3
Converted RemoveFiRStatusFromItemsInContainer into extension method
...
Improved performance of method by using breadth-first search to find children instead of loop
Wrote tests for method
2025-07-30 23:13:09 +01:00
b14b74bf24
Format Style Fixes
2025-07-28 19:39:29 +00:00
623fce1484
Added id generation for BaseClasses, updated references
2025-07-27 17:40:27 +01:00
a1b1c6d815
Updated string to mongoId
2025-07-27 13:31:46 +01:00
7711af53f4
Remove unnecessary conversion to mongoid
2025-07-27 12:57:51 +01:00
680ab40499
Inverted if check to reduce nesting
2025-07-27 12:56:45 +01:00
83cb707551
Updated comment styles
2025-07-27 12:56:09 +01:00
a5c2fb08e6
Style: Satisfy csharpier
2025-07-27 13:54:54 +03:00
82efbfc7db
Refactor Json key name to offerCurrencyChancePercent
2025-07-27 13:36:38 +03:00
bfd616e7c3
Converted rewards data into dictionary - reduced need for reflection
...
Moved clone outside of `UpdateQuestsForGameEdition`
2025-07-26 12:53:56 +01:00
526c3f6c44
string > mongoid
...
added nullguard
2025-07-25 21:12:37 +01:00
5cfb1421c7
Removed unnecessary ??
2025-07-25 20:13:50 +01:00
b1aa8f0942
Removed unnecessary ??
2025-07-25 20:09:07 +01:00
Jesse
Cj
Chomp
sp-tarkov-bot
Lacyway
R3ality