From f0aafc452ffbf8bc392f5f905b659f6cba0af3c8 Mon Sep 17 00:00:00 2001
From: Chomp <dev@dev.sp-tarkov.com>
Date: Sat, 8 Mar 2025 11:26:20 +0000
Subject: [PATCH] Improved logic inside `CreateMagazineTemplate`

---
 .../Controllers/BuildController.cs                | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/Libraries/SPTarkov.Server.Core/Controllers/BuildController.cs b/Libraries/SPTarkov.Server.Core/Controllers/BuildController.cs
index 4f8e2f71..8fdf6b19 100644
--- a/Libraries/SPTarkov.Server.Core/Controllers/BuildController.cs
+++ b/Libraries/SPTarkov.Server.Core/Controllers/BuildController.cs
@@ -199,16 +199,15 @@ public class BuildController(
 
         profile.UserBuildData.MagazineBuilds ??= [];
 
-        var existingArrayId = profile.UserBuildData.MagazineBuilds.FirstOrDefault(item => item.Name == request.Name);
-        if (existingArrayId is not null)
+        // Check if template with desired name already exists and remove it
+        var magazineBuildToRemove = profile.UserBuildData.MagazineBuilds.FirstOrDefault(item => item.Name == request.Name);
+        if (magazineBuildToRemove is not null)
         {
-            {
-                profile.UserBuildData.MagazineBuilds.Remove(existingArrayId);
-            }
-
-
-            profile.UserBuildData.MagazineBuilds.Add(result);
+            profile.UserBuildData.MagazineBuilds.Remove(magazineBuildToRemove);
         }
+
+        // Add new template to profile
+        profile.UserBuildData.MagazineBuilds.Add(result);
     }
 
     /// <summary>