Deconstructed dictionaries to improve readability

2025-06-27 23:21:44 +01:00
parent 6f4bbe02fe
commit d2267847a8
12 changed files with 76 additions and 72 deletions
@@ -141,15 +141,15 @@ public class TraderController(
    {
        var traders = new List<TraderBase>();
        var pmcData = profileHelper.GetPmcProfile(sessionId);
-        foreach (var (traderId, _) in databaseService.GetTables().Traders)
+        foreach (var (traderId, trader) in databaseService.GetTables().Traders)
        {
-            var traderToAdd = traderHelper.GetTrader(traderId, sessionId);
-            if (traderToAdd is null)
+            traderHelper.GetTrader(traderId, sessionId);
+            if (trader.Base is null)
            {
                logger.Warning($"No trader with id: {traderId} found, skipping");
                continue;
            }
-            traders.Add(traderToAdd);
+            traders.Add(trader.Base);

            if (pmcData?.Info != null)
            {