From c8108600ec63d2eaba6be0b8ad473d1027a7d4a9 Mon Sep 17 00:00:00 2001
From: Chomp <dev@dev.sp-tarkov.com>
Date: Sun, 17 Aug 2025 16:40:42 +0100
Subject: [PATCH] Updated `ProcessStaleOffer` and `FlagExpiredOffersAfterDate`
 to use offer object extension method to check if its a trader offer

---
 .../SPTarkov.Server.Core/Services/RagfairOfferService.cs      | 4 ++--
 Libraries/SPTarkov.Server.Core/Utils/RagfairOfferHolder.cs    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Libraries/SPTarkov.Server.Core/Services/RagfairOfferService.cs b/Libraries/SPTarkov.Server.Core/Services/RagfairOfferService.cs
index 6afb2483..903c45d6 100644
--- a/Libraries/SPTarkov.Server.Core/Services/RagfairOfferService.cs
+++ b/Libraries/SPTarkov.Server.Core/Services/RagfairOfferService.cs
@@ -194,8 +194,8 @@ public class RagfairOfferService(
             return;
         }
 
-        // Skip trader offers, managed by RagfairServer.Update() + should remain on flea as 'expired'
-        if (ragfairServerHelper.IsTrader(staleOffer.User.Id))
+        // Skip trader offers, managed by RagfairServer.Update() + should remain on flea as 'expired' until trader refresh occurs
+        if (staleOffer.IsTraderOffer())
         {
             return;
         }
diff --git a/Libraries/SPTarkov.Server.Core/Utils/RagfairOfferHolder.cs b/Libraries/SPTarkov.Server.Core/Utils/RagfairOfferHolder.cs
index 381594d9..b7439671 100644
--- a/Libraries/SPTarkov.Server.Core/Utils/RagfairOfferHolder.cs
+++ b/Libraries/SPTarkov.Server.Core/Utils/RagfairOfferHolder.cs
@@ -401,7 +401,7 @@ public class RagfairOfferHolder(
         {
             foreach (var offer in GetOffers())
             {
-                if (_expiredOfferIds.Contains(offer.Id) || ragfairServerHelper.IsTrader(offer.User.Id))
+                if (_expiredOfferIds.Contains(offer.Id) || offer.IsTraderOffer())
                 {
                     // Already flagged or trader offer (handled separately), skip
                     continue;