From c2e0193450259f3ac51e0563ce6a32d759852594 Mon Sep 17 00:00:00 2001 From: Chomp Date: Thu, 12 Jun 2025 23:03:29 +0100 Subject: [PATCH] Fixed inverted logic inside `GetDeltaQuests` --- .../Helpers/QuestHelper.cs | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/Libraries/SPTarkov.Server.Core/Helpers/QuestHelper.cs b/Libraries/SPTarkov.Server.Core/Helpers/QuestHelper.cs index 9e371c48..2a257ffe 100644 --- a/Libraries/SPTarkov.Server.Core/Helpers/QuestHelper.cs +++ b/Libraries/SPTarkov.Server.Core/Helpers/QuestHelper.cs @@ -105,7 +105,7 @@ public class QuestHelper( var beforeQuests = before.Select(quest => quest.Id).ToHashSet(); // Return quests found in after but not before - return after.Where(quest => beforeQuests.Contains(quest.Id)).ToList(); + return after.Where(quest => !beforeQuests.Contains(quest.Id)).ToList(); } /// @@ -1453,12 +1453,12 @@ public class QuestHelper( fullProfile.CharacterData.ScavData.Quests.Remove(repeatableInScavProfile); } - /** - * Return quests that have different statuses - * @param preQuestStatuses Quests before - * @param postQuestStatuses Quests after - * @returns QuestStatusChange array - */ + /// + /// Get quests that have different statuses + /// + /// Quests before + /// Quests after + /// QuestStatusChange array protected List GetQuestsWithDifferentStatuses( List preQuestStatuses, List postQuestStatuses @@ -1479,12 +1479,12 @@ public class QuestHelper( return result; } - /** - * Does a provided quest have a level requirement equal to or below defined level - * @param quest Quest to check - * @param playerLevel level of player to test against quest - * @returns true if quest can be seen/accepted by player of defined level - */ + /// + /// Does a provided quest have a level requirement equal to or below defined level + /// + /// Quest to check + /// level of player to test against quest + /// true if quest can be seen/accepted by player of defined level protected bool PlayerLevelFulfillsQuestRequirement(Quest quest, double playerLevel) { if (quest.Conditions is null)