Merge pull request #669 from sp-tarkov/Assembly-ref-validation

Validate core assembly reference when loading mods

SPTarkov.Server/Modding/ModValidator.cs

@@ -18,6 +18,12 @@ public class ModValidator(ISptLogger<ModValidator> logger, ServerLocalisationSer
             return [];
         }
 
+        // Validate all assemblies for references. This will deprecate AbstractMetadata semver checks in 4.1
+        foreach (var mod in mods)
+        {
+            ValidateCoreAssemblyReference(mod);
+        }
+
         logger.Info(localisationService.GetText("modloader-loading_mods", mods.Count()));
 
         // Validate and remove broken mods from mod list
@@ -147,6 +153,39 @@ public class ModValidator(ISptLogger<ModValidator> logger, ServerLocalisationSer
         return true;
     }
 
+    /// <summary>
+    ///     Validate that the SPTarkov.Server.Core assembly is compatible with this mod. Semver is not enough.<br/>
+    ///
+    /// Throws an exception if the mod was built for a newer SPT version than the current running SPT version
+    /// </summary>
+    /// <param name="mod">mod to validate</param>
+    protected void ValidateCoreAssemblyReference(SptMod mod)
+    {
+        var sptVersion = ProgramStatics.SPT_VERSION();
+        var modName = $"{mod.ModMetadata.Author}-{mod.ModMetadata.Name}";
+
+        foreach (var assembly in mod.Assemblies)
+        {
+            var sptCoreAsmRefVersion = assembly
+                .GetReferencedAssemblies()
+                .FirstOrDefault(asm => asm.Name == "SPTarkov.Server.Core")
+                ?.Version?.ToString();
+
+            if (sptCoreAsmRefVersion is null)
+            {
+                continue;
+            }
+
+            var modRefVersion = new SemanticVersioning.Version(sptCoreAsmRefVersion?[..^2]!);
+            if (modRefVersion > sptVersion)
+            {
+                throw new Exception(
+                    $"Mod: {modName} requires a minimum SPT version of `{modRefVersion}`, but you are running `{sptVersion}`. Please update SPT to use this mod."
+                );
+            }
+        }
+    }
+
     /// <summary>
     ///     Add into class property "Imported"
     /// </summary>