From b7184f68bd6eff952568f88801081b582332e8f9 Mon Sep 17 00:00:00 2001
From: CWX <cwxdev@outlook.com>
Date: Tue, 28 Jan 2025 19:57:01 +0000
Subject: [PATCH] finish off custom item service

---
 Libraries/Core/Callbacks/NotifierCallbacks.cs    | 1 -
 Libraries/Core/Services/Mod/CustomItemService.cs | 8 +++-----
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/Libraries/Core/Callbacks/NotifierCallbacks.cs b/Libraries/Core/Callbacks/NotifierCallbacks.cs
index dab6522d..97adf5f6 100644
--- a/Libraries/Core/Callbacks/NotifierCallbacks.cs
+++ b/Libraries/Core/Callbacks/NotifierCallbacks.cs
@@ -13,7 +13,6 @@ public class NotifierCallbacks(
     NotifierController _notifierController
 )
 {
-
     /// <summary>
     /// Handle client/notifier/channel/create
     /// </summary>
diff --git a/Libraries/Core/Services/Mod/CustomItemService.cs b/Libraries/Core/Services/Mod/CustomItemService.cs
index 240784ca..e96d7ca6 100644
--- a/Libraries/Core/Services/Mod/CustomItemService.cs
+++ b/Libraries/Core/Services/Mod/CustomItemService.cs
@@ -140,11 +140,9 @@ public class CustomItemService(
      */
     protected void UpdateBaseItemPropertiesWithOverrides(Props? overrideProperties, TemplateItem itemClone)
     {
-        // for (const propKey in overrideProperties) {
-        //     itemClone._props[propKey] = overrideProperties[propKey];
-        // }
-        // TODO: this will need to be different
-        throw new NotImplementedException();
+        foreach (var propKey in overrideProperties.GetAllPropsAsDict()) {
+            itemClone.Properties.GetAllPropsAsDict()[propKey.Key] = overrideProperties.GetAllPropsAsDict()[propKey.Key];
+        }
     }
 
     /**