Move Router, Callbacks and GetResponse over to ValueTask (#325)

* Move Router, Callbacks and GetResponse over to ValueTask

* Assign empty deserializedObject for now, keep todo

* Cleanup GetResponse

* Re-add logger for request
This commit is contained in:
Jesse
2025-05-31 21:30:41 +02:00
committed by GitHub
parent 7f8ca25c3e
commit aafe24eafb
61 changed files with 722 additions and 726 deletions
@@ -2,7 +2,6 @@ using SPTarkov.DI.Annotations;
using SPTarkov.Server.Core.Controllers;
using SPTarkov.Server.Core.Models.Eft.Bot;
using SPTarkov.Server.Core.Models.Eft.Common;
using SPTarkov.Server.Core.Models.Eft.Match;
using SPTarkov.Server.Core.Utils;
namespace SPTarkov.Server.Core.Callbacks;
@@ -18,65 +17,65 @@ public class BotCallbacks(
/// Is called by client to define each bot roles wave limit
/// </summary>
/// <returns></returns>
public string GetBotLimit(string url, EmptyRequestData _, string sessionID)
public ValueTask<string> GetBotLimit(string url, EmptyRequestData _, string sessionID)
{
var splitUrl = url.Split('/');
var type = splitUrl[^1];
return _httpResponseUtil.NoBody(_botController.GetBotPresetGenerationLimit(type));
return new ValueTask<string>(_httpResponseUtil.NoBody(_botController.GetBotPresetGenerationLimit(type)));
}
/// <summary>
/// Handle singleplayer/settings/bot/difficulty
/// </summary>
/// <returns></returns>
public string GetBotDifficulty(string url, EmptyRequestData _, string sessionID)
public ValueTask<string> GetBotDifficulty(string url, EmptyRequestData _, string sessionID)
{
var splitUrl = url.Split('/');
var type = splitUrl[^2].ToLower();
var difficulty = splitUrl[^1];
if (difficulty == "core")
{
return _httpResponseUtil.NoBody(_botController.GetBotCoreDifficulty());
return new ValueTask<string>(_httpResponseUtil.NoBody(_botController.GetBotCoreDifficulty()));
}
return _httpResponseUtil.NoBody(_botController.GetBotDifficulty(sessionID, type, difficulty));
return new ValueTask<string>(_httpResponseUtil.NoBody(_botController.GetBotDifficulty(sessionID, type, difficulty)));
}
/// <summary>
/// Handle singleplayer/settings/bot/difficulties
/// </summary>
/// <returns></returns>
public string GetAllBotDifficulties(string url, EmptyRequestData _, string sessionID)
public ValueTask<string> GetAllBotDifficulties(string url, EmptyRequestData _, string sessionID)
{
return _httpResponseUtil.NoBody(_botController.GetAllBotDifficulties());
return new ValueTask<string>(_httpResponseUtil.NoBody(_botController.GetAllBotDifficulties()));
}
/// <summary>
/// Handle client/game/bot/generate
/// </summary>
/// <returns></returns>
public string GenerateBots(string url, GenerateBotsRequestData info, string sessionID)
public ValueTask<string> GenerateBots(string url, GenerateBotsRequestData info, string sessionID)
{
return _httpResponseUtil.GetBody(_botController.Generate(sessionID, info));
return new ValueTask<string>(_httpResponseUtil.GetBody(_botController.Generate(sessionID, info)));
}
/// <summary>
/// Handle singleplayer/settings/bot/maxCap
/// </summary>
/// <returns></returns>
public string GetBotCap(string url, EmptyRequestData _, string sessionID)
public ValueTask<string> GetBotCap(string url, EmptyRequestData _, string sessionID)
{
var splitUrl = url.Split('/');
var location = splitUrl[^1];
return _httpResponseUtil.NoBody(_botController.GetBotCap(location));
return new ValueTask<string>(_httpResponseUtil.NoBody(_botController.GetBotCap(location)));
}
/// <summary>
/// Handle singleplayer/settings/bot/getBotBehaviours
/// </summary>
/// <returns></returns>
public string GetBotBehaviours()
public ValueTask<string> GetBotBehaviours()
{
return _httpResponseUtil.NoBody(_botController.GetAiBotBrainTypes());
return new ValueTask<string>(_httpResponseUtil.NoBody(_botController.GetAiBotBrainTypes()));
}
}