From a9c33e1dfcd2e5e290b0bc9a39c1ac8a4758531b Mon Sep 17 00:00:00 2001
From: Chomp <dev@dev.sp-tarkov.com>
Date: Tue, 20 May 2025 10:54:32 +0100
Subject: [PATCH] Improved `IsAttachmentAttached` comments

---
 .../SPTarkov.Server.Core/Helpers/ItemHelper.cs    | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs b/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs
index 335bc215..5ac6e56c 100644
--- a/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs
+++ b/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs
@@ -1357,17 +1357,18 @@ public class ItemHelper(
         return currentItem;
     }
 
-    /**
-     * Determines if an item is an attachment that is currently attached to its parent item.
-     *
-     * @param item The item to check.
-     * @returns true if the item is attached attachment, otherwise false.
-     */
+    /// <summary>
+    /// Determines if an item is an attachment that is currently attached to its parent item
+    /// </summary>
+    /// <param name="item">The item to check</param>
+    /// <returns>true if the item is attached attachment, otherwise false</returns>
     public bool IsAttachmentAttached(Item item)
     {
         HashSet<string> check = ["hideout", "main"];
 
-        return !(check.Contains(item.SlotId) || _slotsAsStrings.Contains(item.SlotId) || int.TryParse(item.SlotId, out _));
+        return !(check.Contains(item.SlotId) // Is root item
+                 || _slotsAsStrings.Contains(item.SlotId) // Is root item in equipment slot e.g. `Headwear`
+                 || int.TryParse(item.SlotId, out _)); // Has int as slotId, is inside container. e.g. cartridges
     }
 
     /**