From a57f739c415222c376fa41e58f66871bc2dcee71 Mon Sep 17 00:00:00 2001 From: Chomp Date: Thu, 23 Jan 2025 13:44:36 +0000 Subject: [PATCH] Slightly reduced perf impact of `ReplaceIDs` --- Libraries/Core/Helpers/ItemHelper.cs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Libraries/Core/Helpers/ItemHelper.cs b/Libraries/Core/Helpers/ItemHelper.cs index 9700e907..40db215c 100644 --- a/Libraries/Core/Helpers/ItemHelper.cs +++ b/Libraries/Core/Helpers/ItemHelper.cs @@ -944,11 +944,10 @@ public class ItemHelper( public List ReplaceIDs(List originalItems, PmcData pmcData = null, List insuredItems = null, Dictionary fastPanel = null) { - var items = _cloner.Clone(originalItems); - var serialisedInventory = _jsonUtil.Serialize(items); + var serialisedInventory = _jsonUtil.Serialize(originalItems); var hideoutAreaStashes = pmcData?.Inventory?.HideoutAreaStashes ?? new(); - foreach (var item in items) + foreach (var item in originalItems) { if (pmcData != null) { @@ -985,7 +984,7 @@ public class ItemHelper( } } - items = _jsonUtil.Deserialize>(serialisedInventory); + var items = _jsonUtil.Deserialize>(serialisedInventory); // fix dupe id's var dupes = new Dictionary();