Improved logic inside GenerateModsForWeapon

2025-01-27 13:59:20 +00:00
parent 2f189ad00a
commit 9ff175d877
1 changed files with 8 additions and 7 deletions
@@ -409,13 +409,7 @@ public class BotEquipmentModGenerator(
    /// <returns>Weapon + mods array</returns>
    public List<Item> GenerateModsForWeapon(string sessionId, GenerateWeaponRequest request)
    {
-        if (
-            !(
-                request.ParentTemplate.Properties.Slots.Any() ||
-                request.ParentTemplate.Properties.Cartridges.Any() ||
-                request.ParentTemplate.Properties.Chambers.Any()
-            )
-        )
+        if (ItemLacksSlotsCartridgesAndChambers(request.ParentTemplate))
        {
            _logger.Error(
                _localisationService.GetText(
@@ -691,6 +685,13 @@ public class BotEquipmentModGenerator(
        return request.Weapon;
    }

+    protected bool ItemLacksSlotsCartridgesAndChambers(TemplateItem item)
+    {
+        return item.Properties.Slots?.Count == 0
+               && item.Properties.Cartridges?.Count == 0
+               && item.Properties.Chambers?.Count == 0;
+    }
+
    /// <summary>
    /// Should the provided bot have its stock chance values altered to 100%
    /// </summary>