diff --git a/Libraries/Core/Models/Eft/Common/Tables/BotBase.cs b/Libraries/Core/Models/Eft/Common/Tables/BotBase.cs index da150253..74be0977 100644 --- a/Libraries/Core/Models/Eft/Common/Tables/BotBase.cs +++ b/Libraries/Core/Models/Eft/Common/Tables/BotBase.cs @@ -576,7 +576,7 @@ public record HideoutImprovement public record Production // use this instead of productive and scavcase { - public List? Products { get; set; } + public List? Products { get; set; } /** Seconds passed of production */ public double? Progress { get; set; } @@ -665,17 +665,8 @@ public record HideoutSlot public List? Items { get; set; } } -public record HideoutItem +public record HideoutItem : Item { - [JsonPropertyName("_id")] - public string? Id { get; set; } - - [JsonPropertyName("_tpl")] - public string? Template { get; set; } - - [JsonPropertyName("upd")] - public Upd? Upd { get; set; } - [JsonPropertyName("count")] public double? Count { get; set; } } diff --git a/Libraries/Core/Models/Eft/Common/Tables/Item.cs b/Libraries/Core/Models/Eft/Common/Tables/Item.cs index 89de7475..d1da8c72 100644 --- a/Libraries/Core/Models/Eft/Common/Tables/Item.cs +++ b/Libraries/Core/Models/Eft/Common/Tables/Item.cs @@ -9,7 +9,7 @@ public record Item public required string Id { get; set; } [JsonPropertyName("_tpl")] - public required string Template { get; set; } + public string Template { get; set; } [JsonPropertyName("parentId")] public string? ParentId { get; set; } @@ -25,20 +25,6 @@ public record Item [JsonPropertyName("upd")] public Upd? Upd { get; set; } - - public ItemEvent.Product ConvertToProduct() - { - // TODO - maybe this entire product item can be replaced with Item? - return new ItemEvent.Product - { - Id = Id, - Template = Template, - ParentId = ParentId, - SlotId = SlotId, - Upd = Upd, - Location = (ItemLocation)Location - }; - } } public record ItemLocation diff --git a/Libraries/Core/Models/Eft/Inventory/AddItemDirectRequest.cs b/Libraries/Core/Models/Eft/Inventory/AddItemDirectRequest.cs index 5bda3ae0..6f37f98e 100644 --- a/Libraries/Core/Models/Eft/Inventory/AddItemDirectRequest.cs +++ b/Libraries/Core/Models/Eft/Inventory/AddItemDirectRequest.cs @@ -9,7 +9,7 @@ public record AddItemDirectRequest /// Item and child mods to add to player inventory /// [JsonPropertyName("itemWithModsToAdd")] - public List? ItemWithModsToAdd { get; set; } + public List? ItemWithModsToAdd { get; set; } [JsonPropertyName("foundInRaid")] public bool? FoundInRaid { get; set; } diff --git a/Libraries/Core/Models/Eft/ItemEvent/ItemEventRouterBase.cs b/Libraries/Core/Models/Eft/ItemEvent/ItemEventRouterBase.cs index 1be839ac..1b73ab97 100644 --- a/Libraries/Core/Models/Eft/ItemEvent/ItemEventRouterBase.cs +++ b/Libraries/Core/Models/Eft/ItemEvent/ItemEventRouterBase.cs @@ -136,13 +136,13 @@ public record EquipmentBuildChange public record ItemChanges { [JsonPropertyName("new")] - public List? NewItems { get; set; } + public List? NewItems { get; set; } [JsonPropertyName("change")] - public List? ChangedItems { get; set; } + public List? ChangedItems { get; set; } [JsonPropertyName("del")] - public List DeletedItems { get; set; } // Only needs _id property + public List DeletedItems { get; set; } // Only needs _id property } /** Related to TraderInfo */ @@ -163,7 +163,3 @@ public record TraderData [JsonPropertyName("disabled")] public bool? Disabled { get; set; } } - -public record Product : Item -{ -} diff --git a/Libraries/Core/Routers/ItemEvents/HideoutItemEventRouter.cs b/Libraries/Core/Routers/ItemEvents/HideoutItemEventRouter.cs index 11c5a3fb..4704272f 100644 --- a/Libraries/Core/Routers/ItemEvents/HideoutItemEventRouter.cs +++ b/Libraries/Core/Routers/ItemEvents/HideoutItemEventRouter.cs @@ -70,7 +70,7 @@ public class HideoutItemEventRouter : ItemEventRouterDefinition case HideoutEventActions.HIDEOUT_IMPROVE_AREA: return _hideoutCallbacks.ImproveArea(pmcData, body as HideoutImproveAreaRequestData, sessionID); case HideoutEventActions.HIDEOUT_CANCEL_PRODUCTION_COMMAND: - return _hideoutCallbacks.CancelProduction(pmcData, body as HideoutImproveAreaRequestData, sessionID); + return _hideoutCallbacks.CancelProduction(pmcData, body as HideoutCancelProductionRequestData, sessionID); case HideoutEventActions.HIDEOUT_CIRCLE_OF_CULTIST_PRODUCTION_START: return _hideoutCallbacks.CicleOfCultistProductionStart(pmcData, body as HideoutCircleOfCultistProductionStartRequestData, sessionID); case HideoutEventActions.HIDEOUT_DELETE_PRODUCTION_COMMAND: diff --git a/Libraries/Core/Services/PaymentService.cs b/Libraries/Core/Services/PaymentService.cs index 3b91809b..329b2e73 100644 --- a/Libraries/Core/Services/PaymentService.cs +++ b/Libraries/Core/Services/PaymentService.cs @@ -183,7 +183,7 @@ public class PaymentService( } // Inform client of change to items StackObjectsCount - output.ProfileChanges[sessionID].Items.ChangedItems.Add(_itemHelper.GetProductFromItem(item)); + output.ProfileChanges[sessionID].Items.ChangedItems.Add(item); if (skipSendingMoneyToStash) { break; @@ -275,7 +275,7 @@ public class PaymentService( } else { profileMoneyItem.Upd.StackObjectsCount -= leftToPay; leftToPay = 0; - output.ProfileChanges[sessionID].Items.ChangedItems.Add(_itemHelper.GetProductFromItem(profileMoneyItem)); + output.ProfileChanges[sessionID].Items.ChangedItems.Add(profileMoneyItem); } if (leftToPay == 0) {