From 951ba24d989a92287c572cf202ccebd8050218d3 Mon Sep 17 00:00:00 2001 From: Chomp Date: Sat, 8 Mar 2025 09:33:41 +0000 Subject: [PATCH] Removed reduandant property from method and improved error message text --- .../SPTarkov.Server.Core/Controllers/RagfairController.cs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Libraries/SPTarkov.Server.Core/Controllers/RagfairController.cs b/Libraries/SPTarkov.Server.Core/Controllers/RagfairController.cs index 484ed57e..9fb003e5 100644 --- a/Libraries/SPTarkov.Server.Core/Controllers/RagfairController.cs +++ b/Libraries/SPTarkov.Server.Core/Controllers/RagfairController.cs @@ -456,10 +456,9 @@ public class RagfairController var output = _eventOutputHolder.GetOutput(sessionID); var fullProfile = _profileHelper.GetFullProfile(sessionID); - var validationMessage = ""; - if (!IsValidPlayerOfferRequest(offerRequest, validationMessage)) + if (!IsValidPlayerOfferRequest(offerRequest)) { - return _httpResponseUtil.AppendErrorToOutput(output, validationMessage); + return _httpResponseUtil.AppendErrorToOutput(output, "Unable to add offer, check server for error"); } var typeOfOffer = GetOfferType(offerRequest); @@ -492,9 +491,8 @@ public class RagfairController /// Is the item to be listed on the flea valid /// /// Client offer request - /// message to show to player when offer is invalid /// Is offer valid - protected bool IsValidPlayerOfferRequest(AddOfferRequestData offerRequest, string validationMessage) + protected bool IsValidPlayerOfferRequest(AddOfferRequestData offerRequest) { if (offerRequest?.Items is null || offerRequest.Items.Count == 0) {