From 8ad9afebaa3959cfd9e65dce441555e125249367 Mon Sep 17 00:00:00 2001 From: hulkhan22 Date: Tue, 20 May 2025 11:50:27 +0200 Subject: [PATCH] fix: Insurance removing unremovable parts - #196 (#260) * Fix insurance removing unremovable parts * Mini optimization --- .../SPTarkov.Server.Core/Controllers/InsuranceController.cs | 4 ++-- Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Libraries/SPTarkov.Server.Core/Controllers/InsuranceController.cs b/Libraries/SPTarkov.Server.Core/Controllers/InsuranceController.cs index c276363b..3039c635 100644 --- a/Libraries/SPTarkov.Server.Core/Controllers/InsuranceController.cs +++ b/Libraries/SPTarkov.Server.Core/Controllers/InsuranceController.cs @@ -209,9 +209,9 @@ public class InsuranceController( } // Log the number of items marked for deletion, if any - if (!toDelete.Any()) + if (_logger.IsLogEnabled(LogLevel.Debug)) { - if (_logger.IsLogEnabled(LogLevel.Debug)) + if (toDelete.Any()) { _logger.Debug($"Marked {toDelete.Count} items for deletion from insurance."); } diff --git a/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs b/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs index 4df2aca6..e856e5e0 100644 --- a/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs +++ b/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs @@ -1325,7 +1325,7 @@ public class ItemHelper( false; } - return itemTemplate.Key && parentTemplate.Key && (isNotRaidModdable || isRequiredSlot); + return itemTemplate.Key && parentTemplate.Key && !(isNotRaidModdable || isRequiredSlot); } /// @@ -1367,7 +1367,7 @@ public class ItemHelper( { HashSet check = ["hideout", "main"]; - return !(check.Contains(item.SlotId) || _slotsAsStrings.Contains(item.SlotId) || !int.TryParse(item.SlotId, out _)); + return !(check.Contains(item.SlotId) || _slotsAsStrings.Contains(item.SlotId) || int.TryParse(item.SlotId, out _)); } /**