From 8abb25f508aa33e6b0cb9661f75670ede4258b0c Mon Sep 17 00:00:00 2001
From: Chomp <dev@dev.sp-tarkov.com>
Date: Tue, 5 Aug 2025 23:20:00 +0100
Subject: [PATCH] Improved `AddItemsToStash` Create Add item request once and
 reassign `ItemWithModsToAdd` inside loop

---
 .../Helpers/InventoryHelper.cs                  | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/Libraries/SPTarkov.Server.Core/Helpers/InventoryHelper.cs b/Libraries/SPTarkov.Server.Core/Helpers/InventoryHelper.cs
index 7b2b42b2..d4afb681 100644
--- a/Libraries/SPTarkov.Server.Core/Helpers/InventoryHelper.cs
+++ b/Libraries/SPTarkov.Server.Core/Helpers/InventoryHelper.cs
@@ -59,20 +59,21 @@ public class InventoryHelper(
             return;
         }
 
-        foreach (var itemToAdd in request.ItemsWithModsToAdd)
+        var addItemRequest = new AddItemDirectRequest
         {
-            var addItemRequest = new AddItemDirectRequest
-            {
-                ItemWithModsToAdd = itemToAdd,
-                FoundInRaid = request.FoundInRaid,
-                UseSortingTable = request.UseSortingTable,
-                Callback = request.Callback,
-            };
+            FoundInRaid = request.FoundInRaid,
+            UseSortingTable = request.UseSortingTable,
+            Callback = request.Callback,
+        };
+        foreach (var itemAndChildren in request.ItemsWithModsToAdd)
+        {
+            addItemRequest.ItemWithModsToAdd = itemAndChildren;
 
             // Add to player inventory
             AddItemToStash(sessionId, addItemRequest, pmcData, output);
             if (output.Warnings?.Count > 0)
             {
+                // Adding item to stash failed, don't add remainder
                 return;
             }
         }