Merge pull request #691 from swiftxp-hub/bugfix/key-item-quality

Fixed item quality calculation for keys.
This commit is contained in:
Chomp
2025-11-10 22:58:50 +00:00
committed by GitHub
2 changed files with 3 additions and 5 deletions
+1 -3
View File
@@ -5,9 +5,7 @@
<SptCommit Condition="'$(SptCommit)' == ''">a12b34</SptCommit> <SptCommit Condition="'$(SptCommit)' == ''">a12b34</SptCommit>
<SptBuildTime Condition="'$(SptBuildTime)' == ''">0000000000</SptBuildTime> <SptBuildTime Condition="'$(SptBuildTime)' == ''">0000000000</SptBuildTime>
<SptBuildType Condition="'$(SptBuildType)' == ''">LOCAL</SptBuildType> <SptBuildType Condition="'$(SptBuildType)' == ''">LOCAL</SptBuildType>
<!-- BuildType options - LOCAL, DEBUG, RELEASE, BLEEDINGEDGE, BLEEDINGEDGEMODS - *must be all caps*--> <!-- BuildType options - LOCAL, DEBUG, RELEASE, BLEEDINGEDGE, BLEEDINGEDGEMODS - *must be all caps*--><!-- SemVer-compliant version --><!-- Format: 4.0.1-LOCAL+a12b34.0000000000 -->
<!-- SemVer-compliant version -->
<!-- Format: 4.0.1-LOCAL+a12b34.0000000000 -->
<Version>$(SptVersion)-$(SptBuildType)+$(SptCommit).$(SptBuildTime)</Version> <Version>$(SptVersion)-$(SptBuildType)+$(SptCommit).$(SptBuildTime)</Version>
<AssemblyVersion>$(SptVersion)</AssemblyVersion> <AssemblyVersion>$(SptVersion)</AssemblyVersion>
<FileVersion>$(SptVersion)</FileVersion> <FileVersion>$(SptVersion)</FileVersion>
@@ -616,8 +616,8 @@ public class ItemHelper(
else if (item.Upd.Key?.NumberOfUsages > 0 && itemDetails.Properties?.MaximumNumberOfUsage > 0) else if (item.Upd.Key?.NumberOfUsages > 0 && itemDetails.Properties?.MaximumNumberOfUsage > 0)
{ {
// keys - keys count upwards, not down like everything else // keys - keys count upwards, not down like everything else
var maxNumOfUsages = itemDetails.Properties.MaximumNumberOfUsage; double maxNumOfUsages = itemDetails.Properties.MaximumNumberOfUsage.GetValueOrDefault(0);
result = (maxNumOfUsages ?? 0 - item.Upd.Key.NumberOfUsages) / maxNumOfUsages ?? 0; result = (maxNumOfUsages - item.Upd.Key.NumberOfUsages!.Value) / maxNumOfUsages;
} }
else if (item.Upd.Resource?.UnitsConsumed > 0) // Item is less than 100% usage else if (item.Upd.Resource?.UnitsConsumed > 0) // Item is less than 100% usage
{ {