From 89b5c7e36897d69e2abb2c7d11d65ad87ff8945d Mon Sep 17 00:00:00 2001
From: Chomp <dev@dev.sp-tarkov.com>
Date: Sun, 2 Feb 2025 10:18:16 +0000
Subject: [PATCH] Improved function readability

---
 .../Core/Controllers/PresetController.cs      | 21 ++++++++-----------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/Libraries/Core/Controllers/PresetController.cs b/Libraries/Core/Controllers/PresetController.cs
index 7080d82f..7c18d72f 100644
--- a/Libraries/Core/Controllers/PresetController.cs
+++ b/Libraries/Core/Controllers/PresetController.cs
@@ -14,33 +14,30 @@ public class PresetController(
 )
 {
     /// <summary>
-    /// 
+    /// Keyed by item tpl, value = collection of preset ids
     /// </summary>
     public void Initialize()
     {
         var presets = _databaseService.GetGlobals().ItemPresets;
-        var reverse = new Dictionary<string, List<string>>();
-        foreach (var (key, preset) in presets)
+        var result = new Dictionary<string, HashSet<string>>();
+        foreach (var (presetId, preset) in presets)
         {
-            if (key != preset.Id)
+            if (presetId != preset.Id)
             {
                 _logger.Error(
-                    $"Preset for template tpl: '{preset.Items[0].Template} {preset.Name}' has invalid key: ({key} != {preset.Id}). Skipping"
+                    $"Preset for template tpl: '{preset.Items[0].Template} {preset.Name}' has invalid key: ({presetId} != {preset.Id}). Skipping"
                 );
 
                 continue;
             }
 
             var tpl = preset.Items.FirstOrDefault()?.Template;
-            if (!reverse.ContainsKey(tpl))
-            {
-                reverse[tpl] = [];
-            }
+            result.TryAdd(tpl, []);
 
-            reverse.TryGetValue(tpl, out var listToAddTo);
-            listToAddTo?.Add(preset.Id);
+            result.TryGetValue(tpl, out var listToAddTo);
+            listToAddTo.Add(presetId);
         }
 
-        _presetHelper.HydratePresetStore(reverse);
+        _presetHelper.HydratePresetStore(result);
     }
 }