From 7fefc5d3024102ce3807d778e7a8ccfa0fbaccf5 Mon Sep 17 00:00:00 2001
From: Chomp <dev@dev.sp-tarkov.com>
Date: Sat, 12 Apr 2025 13:56:40 +0100
Subject: [PATCH] Run the dictionary key check first as it's faster compared to
 string compare

---
 Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs b/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs
index 693070e7..52418575 100644
--- a/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs
+++ b/Libraries/SPTarkov.Server.Core/Helpers/ItemHelper.cs
@@ -796,7 +796,7 @@ public class ItemHelper(
             }
 
             // Items parentId matches root item AND returned items doesn't contain current child
-            if (string.Equals(childItem.ParentId,baseItemId, StringComparison.Ordinal) && !result.ContainsKey(childItem.Id))
+            if (!result.ContainsKey(childItem.Id) && string.Equals(childItem.ParentId,baseItemId, StringComparison.Ordinal))
             {
                 foreach (var item in FindAndReturnChildrenAsItems(items, childItem.Id))
                 {