Second attempt at fixing prestige issue #558

Libraries/SPTarkov.Server.Core/Generators/PlayerScavGenerator.cs

@@ -82,7 +82,18 @@ public class PlayerScavGenerator(
             pmcDataClone
         );
 
-        // Remove cached bot data after scav was generated
+        // Add additional items to player scav as loot
+        AddAdditionalLootToPlayerScavContainers(
+            scavData.Id.Value,
+            playerScavKarmaSettings.LootItemsToAddChancePercent,
+            scavData,
+            [EquipmentSlots.TacticalVest, EquipmentSlots.Pockets, EquipmentSlots.Backpack]
+        );
+
+        // No need for cache data, clear up
+        botInventoryContainerService.ClearCache(scavData.Id.Value);
+
+        // Remove cached bot loot cache now scav is generated
         botLootCacheService.ClearCache();
 
         // Add scav metadata
@@ -112,17 +123,6 @@ public class PlayerScavGenerator(
         scavData.WishList = existingScavDataClone.WishList ?? new();
         scavData.Encyclopedia = pmcDataClone.Encyclopedia ?? new();
 
-        // Add additional items to player scav as loot
-        AddAdditionalLootToPlayerScavContainers(
-            scavData.Id.Value,
-            playerScavKarmaSettings.LootItemsToAddChancePercent,
-            scavData,
-            [EquipmentSlots.TacticalVest, EquipmentSlots.Pockets, EquipmentSlots.Backpack]
-        );
-
-        // No need for cache data, clear up
-        botInventoryContainerService.ClearCache(scavData.Id.Value);
-
         // Remove secure container
         scavData = profileHelper.RemoveSecureContainer(scavData);