From 7296ee2c0cd00ba0d0e2a402ea88f059e39e50af Mon Sep 17 00:00:00 2001
From: Chomp <dev@dev.sp-tarkov.com>
Date: Mon, 24 Feb 2025 17:43:32 +0000
Subject: [PATCH] Improved performance of `GetPmcNicknameOfMaxLength` by using
 `any()`

---
 Libraries/Core/Helpers/BotHelper.cs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Libraries/Core/Helpers/BotHelper.cs b/Libraries/Core/Helpers/BotHelper.cs
index 42900e3c..e32f9135 100644
--- a/Libraries/Core/Helpers/BotHelper.cs
+++ b/Libraries/Core/Helpers/BotHelper.cs
@@ -188,12 +188,12 @@ public class BotHelper(
     /// <param name="maxLength">Max length of name, inclusive</param>
     /// <param name="side">OPTIONAL - what side PMC to get name from (usec/bear)</param>
     /// <returns>name of PMC</returns>
-    public string GetPmcNicknameOfMaxLength(int maxLength, string side = null)
+    public string GetPmcNicknameOfMaxLength(int maxLength, string? side = null)
     {
-        var randomType = side is not null ? side : _randomUtil.GetInt(0, 1) == 0 ? "usec" : "bear";
+        var randomType = side ?? (_randomUtil.GetInt(0, 1) == 0 ? "usec" : "bear");
         var allNames = _databaseService.GetBots().Types[randomType.ToLower()].FirstNames;
         var filteredNames = allNames.Where(name => name.Length <= maxLength);
-        if (filteredNames.Count() == 0)
+        if (!filteredNames.Any())
         {
             _logger.Warning(
                 $"Unable to filter: {randomType} PMC names to only those under: {maxLength}, none found that match that criteria, selecting from entire name pool instead`,\n"