From 7168e167dfa8008515e588f4affb548b42ce6896 Mon Sep 17 00:00:00 2001
From: Chomp <dev@dev.sp-tarkov.com>
Date: Thu, 7 Aug 2025 18:15:18 +0100
Subject: [PATCH] Replaced loop with linq inside `GetAllTraderSuits` + return
 IEnumerable

---
 .../Controllers/CustomizationController.cs     | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/Libraries/SPTarkov.Server.Core/Controllers/CustomizationController.cs b/Libraries/SPTarkov.Server.Core/Controllers/CustomizationController.cs
index b993ae2a..a03678ec 100644
--- a/Libraries/SPTarkov.Server.Core/Controllers/CustomizationController.cs
+++ b/Libraries/SPTarkov.Server.Core/Controllers/CustomizationController.cs
@@ -177,20 +177,12 @@ public class CustomizationController(
     /// </summary>
     /// <param name="sessionId">Session/Player id</param>
     /// <returns></returns>
-    protected List<Suit> GetAllTraderSuits(MongoId sessionId)
+    protected IEnumerable<Suit> GetAllTraderSuits(MongoId sessionId)
     {
-        var traders = databaseService.GetTraders();
-        var result = new List<Suit>();
-
-        foreach (var (traderId, trader) in traders)
-        {
-            if (trader.Base.CustomizationSeller is not null && trader.Base.CustomizationSeller.Value)
-            {
-                result.AddRange(GetTraderSuits(traderId, sessionId));
-            }
-        }
-
-        return result;
+        return databaseService
+            .GetTraders()
+            .Where(trader => trader.Value.Base.CustomizationSeller.GetValueOrDefault(false))
+            .SelectMany(trader => GetTraderSuits(trader.Key, sessionId));
     }
 
     /// <summary>