From 71481b3021b027bea0012d5d66c5a1902fd14487 Mon Sep 17 00:00:00 2001
From: Chomp <dev@dev.sp-tarkov.com>
Date: Sat, 19 Jul 2025 13:32:49 +0100
Subject: [PATCH] Removed unnecessary clone from `GetAirdropLootConfigByType`

---
 .../SPTarkov.Server.Core/Services/AirdropService.cs | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/Libraries/SPTarkov.Server.Core/Services/AirdropService.cs b/Libraries/SPTarkov.Server.Core/Services/AirdropService.cs
index 5716cd87..fcdbf5e0 100644
--- a/Libraries/SPTarkov.Server.Core/Services/AirdropService.cs
+++ b/Libraries/SPTarkov.Server.Core/Services/AirdropService.cs
@@ -19,6 +19,7 @@ public class AirdropService(
     ConfigServer configServer,
     ISptLogger<AirdropService> _logger,
     LootGenerator _lootGenerator,
+    DatabaseService databaseService,
     WeightedRandomHelper _weightedRandomHelper,
     ServerLocalisationService _serverLocalisationService,
     ItemFilterService _itemFilterService,
@@ -241,13 +242,11 @@ public class AirdropService(
 
         // Get all items that match the blacklisted types and fold into item blacklist
         var itemTypeBlacklist = _itemFilterService.GetItemRewardBaseTypeBlacklist();
-        var itemsMatchingTypeBlacklist = _itemHelper
-            .GetItemsClone()
-            .Where(templateItem => !templateItem.Parent.IsEmpty())
-            .Where(templateItem =>
-                _itemHelper.IsOfBaseclasses(templateItem.Parent, itemTypeBlacklist)
-            )
-            .Select(templateItem => templateItem.Id)
+        var itemsMatchingTypeBlacklist = databaseService
+            .GetItems()
+            .Where(kvp => !kvp.Value.Parent.IsEmpty())
+            .Where(kvp => _itemHelper.IsOfBaseclasses(kvp.Value.Parent, itemTypeBlacklist))
+            .Select(kvp => kvp.Key)
             .ToHashSet();
         var itemBlacklist = new HashSet<MongoId>();
         itemBlacklist.UnionWith(lootSettingsByType.ItemBlacklist);