Various code quality improvements

This commit is contained in:
Chomp
2025-08-06 12:28:56 +01:00
parent 85a562d1e5
commit 57dde61384
4 changed files with 36 additions and 71 deletions
@@ -1730,7 +1730,7 @@ public class ItemHelper(
var oldRootId = itemWithChildren[0].Id;
Dictionary<string, MongoId> idMappings = [];
idMappings[oldRootId.ToString()] = rootItem.Id;
idMappings[oldRootId] = rootItem.Id;
foreach (var mod in itemWithChildren)
{
@@ -1805,44 +1805,13 @@ public class ItemHelper(
public int GetRandomisedAmmoStackSize(TemplateItem ammoItemTemplate, int maxLimit = 60)
{
return ammoItemTemplate.Properties?.StackMaxSize == 1
? 1
? 1 // Max is one, nothing to randomise
: randomUtil.GetInt(
ammoItemTemplate.Properties?.StackMinRandom ?? 1,
Math.Min(ammoItemTemplate.Properties?.StackMaxRandom ?? 1, maxLimit)
);
}
public MongoId? GetItemBaseType(MongoId tpl, bool rootOnly = true)
{
var result = GetItem(tpl);
if (!result.Key)
// Not an item
{
return null;
}
var currentItem = result.Value;
while (currentItem is not null)
{
if (currentItem.Type == "Node" && !rootOnly)
// Hit first base type
{
return currentItem.Id;
}
if (currentItem.Parent.IsEmpty())
// No parent, reached root
{
return currentItem.Id;
}
// Get parent item and start loop again
currentItem = GetItem(tpl).Value;
}
return null;
}
/// <summary>
/// Get a 2D grid of a container's item slots
/// </summary>