From 356e6de7ed5915282674a6515699653e65203094 Mon Sep 17 00:00:00 2001
From: Chomp <dev@dev.sp-tarkov.com>
Date: Sun, 6 Jul 2025 13:10:48 +0100
Subject: [PATCH] Fixed `CreateSacrificeCacheKey` failing to create key from
 MongoIds #456

---
 .../Services/CircleOfCultistService.cs             | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/Libraries/SPTarkov.Server.Core/Services/CircleOfCultistService.cs b/Libraries/SPTarkov.Server.Core/Services/CircleOfCultistService.cs
index 59130f03..2e858d8a 100644
--- a/Libraries/SPTarkov.Server.Core/Services/CircleOfCultistService.cs
+++ b/Libraries/SPTarkov.Server.Core/Services/CircleOfCultistService.cs
@@ -962,19 +962,13 @@ public class CircleOfCultistService(
     }
 
     /// <summary>
-    /// Temporary until MongoId conversion is done, should be removed and the mongoid one kept in place
+    /// Create an MD5 hash of the passed in items
     /// </summary>
-    /// <param name="requiredItems"></param>
-    /// <returns></returns>
-    protected string CreateSacrificeCacheKey(IEnumerable<string> requiredItems)
-    {
-        var concat = string.Join(",", requiredItems.OrderBy(item => item));
-        return hashUtil.GenerateHashForData(HashingAlgorithm.MD5, concat);
-    }
-
+    /// <param name="requiredItems">Items to create key for</param>
+    /// <returns>Key</returns>
     protected string CreateSacrificeCacheKey(IEnumerable<MongoId> requiredItems)
     {
-        var concat = string.Join(",", requiredItems.OrderBy(item => item));
+        var concat = string.Join(",", requiredItems.OrderBy(item => item.ToString()));
         return hashUtil.GenerateHashForData(HashingAlgorithm.MD5, concat);
     }