From 2bdab2d7b62a1608e82b5a7adebeaf2c4b4080c5 Mon Sep 17 00:00:00 2001 From: Chomp Date: Sat, 8 Mar 2025 11:18:28 +0000 Subject: [PATCH] Updated `GetAchievementStatics` to loop through ids, not achievement objects --- .../Controllers/AchievementController.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/SPTarkov.Server.Core/Controllers/AchievementController.cs b/Libraries/SPTarkov.Server.Core/Controllers/AchievementController.cs index d924c04b..5b4fae73 100644 --- a/Libraries/SPTarkov.Server.Core/Controllers/AchievementController.cs +++ b/Libraries/SPTarkov.Server.Core/Controllers/AchievementController.cs @@ -40,7 +40,7 @@ public class AchievementController( var profiles = profileHelper.GetProfiles(); var achievements = databaseService.GetAchievements(); - foreach (var achievement in achievements) { + foreach (var achievementId in achievements.Select(achievement => achievement.Id).Where(achievementId => !string.IsNullOrEmpty(achievementId))) { var percentage = 0; foreach (var (profileId, profile) in profiles) { if (coreConfig.Features.AchievementProfileIdBlacklist.Contains(profileId)) @@ -53,7 +53,7 @@ public class AchievementController( continue; } - if (!profile.CharacterData.PmcData.Achievements.ContainsKey(achievement.Id)) + if (!profile.CharacterData.PmcData.Achievements.ContainsKey(achievementId)) { continue; } @@ -62,7 +62,7 @@ public class AchievementController( } percentage = (percentage / profiles.Count) * 100; - stats.Add(achievement.Id, percentage); + stats.Add(achievementId, percentage); } return new CompletedAchievementsResponse{ Elements = stats };