From 1572a54f40b5b54f7d5fa1c4874ac196a9665a9c Mon Sep 17 00:00:00 2001 From: CWX Date: Wed, 23 Apr 2025 15:13:02 +0100 Subject: [PATCH] Remove logging Requests --- .../Servers/Http/RequestLogger.cs | 6 ---- .../Servers/Http/SptHttpListener.cs | 27 --------------- SPTarkov.Server/appsettings.Development.json | 33 ------------------- SPTarkov.Server/appsettings.json | 6 ---- 4 files changed, 72 deletions(-) delete mode 100644 Libraries/SPTarkov.Server.Core/Servers/Http/RequestLogger.cs diff --git a/Libraries/SPTarkov.Server.Core/Servers/Http/RequestLogger.cs b/Libraries/SPTarkov.Server.Core/Servers/Http/RequestLogger.cs deleted file mode 100644 index ff1a7e43..00000000 --- a/Libraries/SPTarkov.Server.Core/Servers/Http/RequestLogger.cs +++ /dev/null @@ -1,6 +0,0 @@ -namespace SPTarkov.Server.Core.Servers.Http; - -// This is a dummy class to use for SourceContext in Serilog, do not remove! -public class RequestLogger -{ -} diff --git a/Libraries/SPTarkov.Server.Core/Servers/Http/SptHttpListener.cs b/Libraries/SPTarkov.Server.Core/Servers/Http/SptHttpListener.cs index 28144162..7245f835 100644 --- a/Libraries/SPTarkov.Server.Core/Servers/Http/SptHttpListener.cs +++ b/Libraries/SPTarkov.Server.Core/Servers/Http/SptHttpListener.cs @@ -26,7 +26,6 @@ public class SptHttpListener : IHttpListener protected readonly JsonUtil _jsonUtil; protected readonly LocalisationService _localisationService; protected readonly ISptLogger _logger; - protected readonly ISptLogger _requestLogger; protected readonly HttpRouter _router; @@ -36,7 +35,6 @@ public class SptHttpListener : IHttpListener HttpRouter httpRouter, IEnumerable serializers, ISptLogger logger, - ISptLogger requestsLogger, JsonUtil jsonUtil, HttpResponseUtil httpHttpResponseUtil, LocalisationService localisationService @@ -45,7 +43,6 @@ public class SptHttpListener : IHttpListener _router = httpRouter; _serializers = serializers; _logger = logger; - _requestLogger = requestsLogger; _httpResponseUtil = httpHttpResponseUtil; _localisationService = localisationService; _jsonUtil = jsonUtil; @@ -156,7 +153,6 @@ public class SptHttpListener : IHttpListener { // Send only raw response without transformation SendJson(resp, output, sessionID); - LogRequest(req, output); return; } @@ -171,8 +167,6 @@ public class SptHttpListener : IHttpListener { SendZlibJson(resp, output, sessionID); } - - LogRequest(req, output); } /// @@ -185,20 +179,6 @@ public class SptHttpListener : IHttpListener return req.Headers.TryGetValue("responsecompressed", out var value) && value == "0"; } - /// - /// Log request if enabled - /// - /// Log request if enabled - /// Output string - protected void LogRequest(HttpRequest req, string output) - { - if (ProgramStatics.ENTRY_TYPE() != EntryType.RELEASE) - { - var log = new Response(req.Method, output.Substring(0, Math.Min(output.Length, 8000))); - _requestLogger.Info($"RESPONSE={_jsonUtil.Serialize(log)}"); - } - } - public string GetResponse(string sessionID, HttpRequest req, string? body) { var output = _router.GetResponse(req, sessionID, body, out var deserializedObject); @@ -210,13 +190,6 @@ public class SptHttpListener : IHttpListener output = _httpResponseUtil.GetBody(null, BackendErrorCodes.HTTPNotFound, $"UNHANDLED RESPONSE: {req.Path.ToString()}"); } - if (ProgramStatics.ENTRY_TYPE() != EntryType.RELEASE) - { - // Parse quest info into object - var log = new Request(req.Method, new RequestData(req.Path, req.Headers, deserializedObject)); - _requestLogger.Info($"REQUEST={_jsonUtil.Serialize(log)}"); - } - return output; } diff --git a/SPTarkov.Server/appsettings.Development.json b/SPTarkov.Server/appsettings.Development.json index 7301b71c..8f482ea6 100644 --- a/SPTarkov.Server/appsettings.Development.json +++ b/SPTarkov.Server/appsettings.Development.json @@ -26,12 +26,6 @@ "Args": { "configureLogger": { "Filter": [ - { - "Name": "ByExcluding", - "Args": { - "expression": "StartsWith(SourceContext, 'SPTarkov.Server.Core.Servers.Http.RequestLogger')" - } - }, { "Name": "ByExcluding", "Args": { @@ -60,33 +54,6 @@ } } }, - { - "Name": "Logger", - "Args": { - "configureLogger": { - "Filter": [ - { - "Name": "ByIncludingOnly", - "Args": { - "expression": "StartsWith(SourceContext, 'SPTarkov.Server.Core.Servers.Http.RequestLogger')" - } - } - ], - "WriteTo": [ - { - "Name": "File", - "Args": { - "formatter": "SPTarkov.Server.Logger.FileFormatter::Default, SPTarkov.Server", - "path": "./user/logs/requests/requests.txt", - "rollingInterval": "Day", - "fileSizeLimitBytes": "20971520", - "rollOnFileSizeLimit": true - } - } - ] - } - } - }, { "Name": "Logger", "Args": { diff --git a/SPTarkov.Server/appsettings.json b/SPTarkov.Server/appsettings.json index f1c901a8..7dc454e5 100644 --- a/SPTarkov.Server/appsettings.json +++ b/SPTarkov.Server/appsettings.json @@ -26,12 +26,6 @@ "Args": { "configureLogger": { "Filter": [ - { - "Name": "ByExcluding", - "Args": { - "expression": "StartsWith(SourceContext, 'SPTarkov.Server.Core.Servers.Http.RequestLogger')" - } - }, { "Name": "ByExcluding", "Args": {